Bug 240828

Summary:	media-sound/mp3gain: C(XX)FLAGS are ignored (at src_configure/compile)
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Tony Vroon (RETIRED) <chainsaw>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sound
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-10-09 21:32:57 UTC

I don't know the build system for this program (and this is a generic bug template so I cannot tell you which program exactly is), but my tests shows that it's not respecting CFLAGS (or CXXFLAGS) properly.

Please look into it, since it's important to respect user CFLAGS and CXXFLAGS.

Warning: this bug might look like a false positive because you actually have your CFLAGS being used; this happens if the CFLAGS are "set in stone" in the build system during src_unpack/src_prepare. While QA has not as of this moment expressed to me a preference, I'd sincerely suggest to avoid the set-in-stone approach, so that ebuild commands could work to reproduce the actual results.

To avoid the set in stone approach:

- consider just changing CFLAGS= to CFLAGS+= if the build system enables warnings;
- if the buildsystem does not use CFLAGS variable at all, in the sed use '$(CFLAGS)', single quoted, so that the CFLAGS variable is picked up;
- use '$(OPTCFLAGS)' in the sed and then use make OPTCFLAGS=$CFLAGS.

Thanks,
Diego

Comment 1 Tony Vroon (RETIRED) gentoo-dev

2008-10-11 23:24:51 UTC

False positive, CFLAGS were respected. Will make some changes based on your warning though.

Comment 2 Tony Vroon (RETIRED) gentoo-dev

2008-10-11 23:27:41 UTC

+*mp3gain-1.4.6-r2 (11 Oct 2008)
+
+  11 Oct 2008; <chainsaw@gentoo.org> +mp3gain-1.4.6-r2.ebuild:
+  Do not set CFLAGS in stone during src_unpack stage to avoid triggering the
+  mass CFLAGS bug filing framework. Use toolchain-funcs eclass to set CC.
+  Closes bug #240808 by Diego "Flameeyes" Pettenò <flameeyes@gentoo.org>.