Summary: | app-text/7plus: CFLAGS are ignored | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | New packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | tomjbe |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | patch to fix CFLAGS ignoring and pre-strip problem wrt bug 240108 |
Description
Diego Elio Pettenò (RETIRED)
2008-10-05 20:43:30 UTC
Can not reproduce the problem. See tests below. How do you test that, Diego? Test 1: > emerge --info ... CBUILD="i686-pc-linux-gnu" CFLAGS="-O2 -mtune=athlon-4" CHOST="i686-pc-linux-gnu" ... > emerge 7plus ... >>> Compiling source in /var/tmp/portage/app-text/7plus-2.25/work/7plsrc.225 ... i686-pc-linux-gnu-gcc -c -O2 -mtune=athlon-4 -Wall 7plus.c i686-pc-linux-gnu-gcc -c -O2 -mtune=athlon-4 -Wall encode.c Test 2: > CFLAGS="will_not_compile" emerge 7plus ... i686-pc-linux-gnu-gcc -c will_not_compile -Wall 7plus.c i686-pc-linux-gnu-gcc -c will_not_compile -Wall encode.c i686-pc-linux-gnu-gcc: will_not_compile: No such file or directory Created attachment 167646 [details] patch to fix CFLAGS ignoring and pre-strip problem wrt bug 240108 Thanks to Diego's clarification in http://blog.flameeyes.eu/2008/10/08/more-notes-about-the-flags-testing I found the problem. Attached patch fixes the problem by sed'ing 'CFLAGS =' into 'CFLAGS +=' in the Makefile. Be careful as the patch is a cumulative one, which fixes also the pre-strip problem from Bug 240108. 03 Jan 2009; Mike Pagano <mpagano@gentoo.org> 7plus-2.25.ebuild: Fix for respecting CFLAGS bug #240125 and prestriping binaries bug #240108. Patch submitted by Thomas Beierlein. Thank-you, Thomas. |