Bug 239970 – app-crypt/nistp224: CFLAGS are ignored

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Diego Elio Pettenò (RETIRED) 2008-10-05 13:31:26 UTC]

I don't know the build system for this program (and this is a generic bug template so I cannot tell you which program exactly is), but my tests shows that it's not respecting CFLAGS properly.

Please look into it, since it's important to respect user CFLAGS.

Thanks,
Diego

[Comment 1 Thilo Bangert (RETIRED) (RETIRED) 2008-10-05 20:10:00 UTC]

thanks diego.

could i get you to clue me in on how you checked it?
my CFLAGS are CFLAGS="-O2 -march=pentium3 -fomit-frame-pointer -pipe" and the compiler uses these args:

i686-pc-linux-gnu-gcc -O2 -march=pentium3 -fomit-frame-pointer -pipe -fPIC -c 

which looks ok to me...
thanks.

[Comment 2 Diego Elio Pettenò (RETIRED) 2008-10-05 22:16:01 UTC]

I think thanks to Mike I found what the problem is here: my script assumes that changing CFLAGS during src_compile/src_configure is good enough; nistp224 writes the CFLAGS during src_unpack, and that is what triggers it.

Now I admit it's debatable, so I guess I'll leave it up to you to choose whether to "fix" it (as I'd sincerely like) so that src_configure/src_compile is the function where they would be set in stone, or close as WORKSFORME if you don't care.

[Comment 3 Thilo Bangert (RETIRED) (RETIRED) 2009-03-16 11:16:03 UTC]

introduced src_configure in -r1.