Bug 23957 – rc.conf should support any existing X display manager (Patch)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Mamoru KOMACHI (RETIRED) 2003-07-04 17:52:18 UTC]

Hi.

Recently I tried to use wdm as an X display manager on Gentoo boxes
and found that wdm is not supported by /etc/rc.conf and /etc/init.d/xdm
even though wdm is in portage. /etc/init.d/xdm doesn't seem to support
other xdm except for gdm, kdm, elogin, entrance and xdm. If 
/etc/init.d/xdm detects xdm other than those above, it defaults to
xdm (so that we cannot use wdm). So I made small diffs to patch up
/etc/rc.conf (in sys-apps/baselayout/files/rc-scripts-1.4.3.8p1.tar.bz2)
and xdm.start (in x11-base/xfree/files/4.3.0). 

Regards,

Mamoru KOMACHI aka usata

[Comment 1 Mamoru KOMACHI (RETIRED) 2003-07-04 17:52:54 UTC]

Created attachment 14163 [details, diff]
/etc/rc.conf.diff

[Comment 2 Mamoru KOMACHI (RETIRED) 2003-07-04 17:53:39 UTC]

Created attachment 14164 [details, diff]
xdm.start.diff

[Comment 3 Martin Schlemmer (RETIRED) 2003-07-17 12:26:06 UTC]

Created attachment 14630 [details, diff]
xdm.diff

I think its just too hardcoded in general.  Something more generic
like in the patch will suite this and future much better.

[Comment 4 Martin Schlemmer (RETIRED) 2003-07-24 11:37:14 UTC]

Does this solve it for you ?

[Comment 5 Mamoru KOMACHI (RETIRED) 2003-07-24 21:45:53 UTC]

Created attachment 14981 [details]
xdm.start.diff

[Comment 6 Mamoru KOMACHI (RETIRED) 2003-07-24 21:50:13 UTC]

Thanks :) Sorry I didn't realise you posted a patch. 
Your xdm.diff doesn't quite solve the problem, 
but having added 

MY_XDM=`echo ${MY_XDM} | tr [:upper:] [:lower:]`

before 

for x in /usr/bin /usr/X11R6/bin
do
    [ -x "${x}/${MY_XDM}" ] && EXE="${x}/${MY_XDM}"
done

it does, because at the top of setup_dm() ${MY_XDM} is converted
into upper case so that it needs to be reconverted into lower case.

However, it doesn't seem to be necessary to have that variable 
in upper case, so I think it would be better to change ${MY_XDM}
to lower case. Attached xdm.start.diff works fine for me.

[Comment 7 Ondrej Jombik 2003-09-08 05:24:16 UTC]

Please just add this into /etc/init.d/xdm:

        WDM)
            EXE=/usr/bin/wdm
            ;;

It works well for me with this change (using recent Gentoo 1.4).

Nepto, http://nepto.sk/

[Comment 8 Andrew Bevitt 2003-11-23 17:53:19 UTC]

Created attachment 21188 [details, diff]
Patch for init script

Adding WDM to xdm.start in both the 4.3.99.x files package, and in the FILESDIR
for 4.3 and prior versions seems suitable. This patch does that, just needs to
be commited upstream.

[Comment 9 Donnie Berkholz (RETIRED) 2003-12-03 22:43:27 UTC]

Added the hardcoded patch in comment #8 for now. Plan to test the general solution more.

[Comment 10 Donnie Berkholz (RETIRED) 2004-03-17 11:38:55 UTC]

Fixed in 4.3.0-r6 with wdm-only patch for now.

[Comment 11 Karl Trygve Kalleberg (RETIRED) 2004-09-10 02:09:55 UTC]

The latest xdm.start.diff looks good. However, given Donnie's latest protests
about programs inserting their files into /usr/X11R6, I suggest we don't 
pick up DMs there (apart from xdm itself, of course).

Furthermore, calling which has the unintended? side-effect that it will pick
up DMs outside the "core" paths if root has extra entries in the path, but
I'm not so certain this is really a Bad Thing.

[Comment 12 Donnie Berkholz (RETIRED) 2004-09-14 16:35:47 UTC]

Fixed in 6.8.0, FILES_VER 0.2. Sync in an hour or so to get it.

Karl, if you have concerns with the `which`, please file a new bug.