Bug 239504

Summary:	New ebuild: net-analyzer/yaph
Product:	Gentoo Linux	Reporter:	J M W <ultip>
Component:	New packages	Assignee:	Default Assignee for New Packages <maintainer-wanted>
Status:	CONFIRMED ---
Severity:	normal	CC:	tommy
Priority:	High	Keywords:	EBUILD, REVIEWED
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://yaph.sourceforge.net
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	yaph-0.91.ebuild init.c patch tcp_utils.c patch Updated ebuild

Description J M W 2008-10-04 06:36:20 UTC

New ebuild for net-analyzer/yaph.

Reproducible: Always

Comment 1 J M W 2008-10-04 06:39:13 UTC

Created attachment 167125 [details]
yaph-0.91.ebuild

Comment 2 J M W 2008-10-04 06:40:33 UTC

Created attachment 167126 [details, diff]
init.c patch

Comment 3 J M W 2008-10-04 06:41:11 UTC

Created attachment 167127 [details]
tcp_utils.c patch

Comment 4 Thomas Sachau gentoo-dev

2008-10-04 21:12:00 UTC

Some comments on the ebuild: 

-HOMEPAGE should begin with http://
-in SRC_URI, you can use ${PN}
-LICENSE is invalid, probably GPL-2?
-you can drop empty DEPEND and RDEPEND
-cd "${S}/" <<< you dont need the / here
-pwd in the following line can be dropped

Comment 5 J M W 2008-10-05 03:46:43 UTC

Created attachment 167241 [details]
Updated ebuild

Suggestions implemented. Thanks!

Comment 6 Thomas Sachau gentoo-dev

2008-10-05 12:18:12 UTC

Looks ok to me now. For better readability, you could have used tabs like:

src_unpack() {
        unpack ${A}
        ...
}