Summary: | kde-base/kdemultimedia-kioslaves-3.5.10 does not compile with media-sound/cdparanoia-3.10.2 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Matthias Liebig <pqGungnir> |
Component: | [OLD] KDE | Assignee: | Gentoo Sound Team <sound> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ian, jlhamm, jlp.bugs, kde, manschwetus, zelegolas |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build.log
Ebuild Patch cdparanoia-3.10.2.ebuild Rename member 'private' in cdda_interface.h |
Description
Matthias Liebig
2008-09-22 12:01:38 UTC
Created attachment 166085 [details]
build.log
in cdda_interface.h we find: 45: typedef struct cdda_private_data cdda_private_data_t; 87: cdda_private_data_t *private; struct cdda_private_data is defined in low_interface.h of the source tarball, but it seems not to be installed (and not even included from the cdda_interface.h). (In reply to comment #2) > struct cdda_private_data is defined in low_interface.h of the source tarball, > but it seems not to be installed (and not even included from the > cdda_interface.h). No, that's not the problem. cdda_interface.h is used from a C++ file (encodercda.cpp). In C++ "private" has a special meaning (keyword?), so the field name within the struct should be changed. I'll send a mail to the author of cdparanoia. It's now fixed in the svn (r15338): 'private' as a reserved keyword now being enforced by GCC 4.3, causes a build failure (patched in SVN) Created attachment 166305 [details, diff]
Ebuild Patch
I compared the upstream SVN copy with the current branch and made a nice sed line that will apply the same fix for those whom want a "now" fix.
Works for me :)
In case it wasn't obvious ( theres already been one missunderstanding ), the .patch ( file 166305 ) may not be friendly enough to just "snap in". Read it and apply as needed to your own .ebuild file. ;) Its diffing 2 files in 2 different locations, so .. yeah. read code before applying :) Created attachment 166334 [details]
cdparanoia-3.10.2.ebuild
Seeing people get confused really easy ( *rolls eyes* ) here is a patched ebuild for your amusement.
Created attachment 166336 [details, diff]
Rename member 'private' in cdda_interface.h
Using 'sed' in the ebuild is too fugly for me, so here's a patch for the cdparanoia 3.10.2 source - cdparanoia-3.10.2-gcc43.patch
The existing epatch in the ebuild could be extended to apply this patch.
(In reply to comment #8) > The existing epatch in the ebuild could be extended to apply this patch. Like this: epatch \ "${FILESDIR}"/${PN}-3.10.2-use-destdir.patch \ "${FILESDIR}"/${PN}-3.10.2-Makefile.in.patch \ "${FILESDIR}"/${PN}-3.10.2-gcc43.patch *** Bug 238375 has been marked as a duplicate of this bug. *** @media-sound: Can we get a patch for cdparanoia or an updated version? Why, certainly. +*cdparanoia-3.10.2-r1 (26 Sep 2008) + + 26 Sep 2008; Peter Alfredsen <loki_val@gentoo.org> + +files/cdparanoia-3.10.2-gcc43.patch, -cdparanoia-3.10.2.ebuild, + +cdparanoia-3.10.2-r1.ebuild: + Fix bug 238378. Thanks to Matthias Liebig <pqGungnir@gmx.de> and Ian + Abbott <ian@abbott.org>. + *** Bug 238835 has been marked as a duplicate of this bug. *** |