Summary: | media-sound/alsa-driver-1.0.17: unable to customize --with-card-options | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Dmitry Ivankov <divanorama> |
Component: | New packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | Inclusion |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Dmitry Ivankov
2008-09-14 21:14:19 UTC
(In reply to comment #0) > To use sound in my fujitsu amilo pro v2040 laptop I needed to use hda-intel > module with hda-generic codec (looks like wrong codec is autodetected > otherwise). > > Reproducible: Always > > Steps to Reproduce: > 1.Add ALSA_CARDS="hda-intel" > 2.Add ALSA_CARD_OPTIONS="hda-generic" to /etc/make.conf > 3.emerge alsa-driver > > > Actual Results: > Alsa driver is configured with --with-cards="hda-intel" > --with-card-options="hda-generic" > > Expected Results: > Alsa driver is configured with --with-cards="hda-intel" > --with-card-options="all" > > Here is a diff to alsa-driver-1.0.17 which allows ALSA_CARD_OPTIONS > customization. Probably it should be enhanced to make friends with IUSE > > 65a66 > > ALSA_CARD_OPTIONS=${ALSA_CARD_OPTIONS:-"all"} > 141c142 > < --with-card-options=all" || die "econf failed" > --- > > --with-card-options=${ALSA_CARD_OPTIONS}" || die "econf failed" > I assume you got your Actual and Expected results switched, since it does do "all" by default. That's probably not a bad idea adding on a separate option, but we'd want to document it somewhere ... or something. Not sure what to do with that. Might make more sense to just set it to use flags. As far as the bug, can you try the 1.0.18rc3 and see if that fixes it? > I assume you got your Actual and Expected results switched, since it does do > "all" by default. Oh, sure :) > That's probably not a bad idea adding on a separate option, but we'd want to > document it somewhere ... or something. Not sure what to do with that. Might > make more sense to just set it to use flags. Hmm maybe, I just saw somewhere that ALSA_CARDS in make.conf is a proper way to set cards. I like the idea of deprecating that way and encouraging using flags. The only thing is that use flags list have to be updated if some cards/options are added/removed in next versions. > As far as the bug, can you try the 1.0.18rc3 and see if that fixes it? Looks like it does :) I've copied clean alsa-headers-1.0.17 and alsa-driver-1.0.17 ebuilds to *-1.0.18_rc3, patched driver ebuild to reference new headers version, unmasked, emerged, restarted alsasound and sound still works. cat /proc/asound/version says it's really 1.0.18rc3 And then I synced :)) Unmerged my versions, removed them from overlay, emerged alsa-driver-1.0.18_rc3 (it pulled alsa-headers-1.0.17), restarted alsasound. Sound still works. So probably bug's priority decreases. Closing then since all versions in the tree should work ok |