Bug 237616

Summary:	Kbuild: Make KBUILD_EXTRA_SYMBOLS working
Product:	Gentoo Linux	Reporter:	Peter Volkov (RETIRED) <pva>
Component:	[OLD] Unspecified	Assignee:	Gentoo Kernel Bug Wranglers and Kernel Maintainers <kernel>
Status:	RESOLVED UPSTREAM
Severity:	normal	CC:	gengor
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://bugzilla.kernel.org/show_bug.cgi?id=11567
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	linux-2.6-KBUILD_EXTRA_SYMBOLS.patch

Description Peter Volkov (RETIRED) gentoo-dev

2008-09-14 10:22:04 UTC

If you even define KBUILD_EXTRA_SYMBOLS in Makefile for modules it will not be expanded into command line argument for modpost.

KBUILD_EXTRA_SYMBOLS help helps to fix undefined symbols errors when CONFIG_MODVERSIONS is set and CONFIG_MODULE_FORCE_LOAD is not set.

Comment 1 Peter Volkov (RETIRED) gentoo-dev

2008-09-14 10:22:39 UTC

Created attachment 165385 [details, diff]
linux-2.6-KBUILD_EXTRA_SYMBOLS.patch

This patch fixes the problem here.

Comment 2 Daniel Drake (RETIRED) gentoo-dev

2008-10-28 23:22:29 UTC

Where did the patch come from? It does not seem to have been applied upstream.

Comment 3 Daniel Drake (RETIRED) gentoo-dev

2008-10-28 23:22:50 UTC

wrongly reassigned this one

Comment 4 Peter Volkov (RETIRED) gentoo-dev

2008-10-29 08:28:06 UTC

(In reply to comment #2)
> Where did the patch come from?

From me.

> It does not seem to have been applied upstream.

It's still not in linus tree but it was included in mm tree and although I've tried to mail this patch to linux-kernel as Andrew Morton told me to do I've seen no reaction on my mail. 25 Oct 2008 I've received mail from 
akpm AT linux-foundation.org to me, Sam Ravnborg and again akpm with this patch inside, but I have no ideas on intentions of that mail...


But that's said, I've found that although this KBUILD_EXTRA_SYMBOLS is broken it's not required for madwifi-ng. That's why I think we can wait that one day somebody finally fixes this issue UPSTREAM and that's how we'll get fixed version in Gentoo. I think currently there is no need for our kernel team to spend time on this issue. Resolving as UPSTREAM.

Comment 5 Peter Volkov (RETIRED) gentoo-dev

2008-10-30 05:59:01 UTC

And now I've received copy of mail from Sam Ravnborg to Linus Torvalds which is pull request where this patch is included. So this fix is closer to became included upstream AFAIU. The fun note is that this pull request includes two patches from Gentoo developers:

Mike Frysinger (1):
      kbuild: setlocalversion: dont include svn change count

Peter Volkov (1):
      kbuild: fix KBUILD_EXTRA_SYMBOLS

Gentoo is still working with upstream to make our distribution better:)