Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 237307

Summary: Formatted diff has problems with minus characters
Product: Gentoo Infrastructure Reporter: Martin von Gagern <Martin.vGagern>
Component: BugzillaAssignee: Gentoo Linux bug wranglers <bug-wranglers>
Severity: minor    
Priority: High    
Version: unspecified   
Hardware: All   
OS: All   
Package list:
Runtime testing required: ---

Description Martin von Gagern 2008-09-10 11:30:52 UTC
See this attachment here:

As you can see, both the coloured and the processed unified patch have problems with the lines starting in "-----" in the original file. I guess this is due to some confusion with the "---" introducing the fist input file of an unified patch. If that is the case, maybe you should rather check for "--- ", i.e. make the space character part of the search pattern.
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2008-09-10 17:27:35 UTC
I don't see a problem tbh, don't use the "diff" feature. Anyway, if it can be fixed, it needs to be fixed upstream anyway. You should file a bug at Keep in mind that we use version 2.22 and 3.2 is now released. bug #213782
Comment 2 Martin von Gagern 2008-09-10 19:03:45 UTC
Issue is known upstream:
Still present in latest CVS version. Sorry I didn't look upstream first.
Seems to come from a bug in PatchReader perl module. I can't reach the perl issue tracker atm, so I don't know what details might be available on
Would this issue here be better off closed as UPSTREAM?