Bug 236950

Summary:	www-client/opera-9.52: remove unneeded md5check
Product:	Gentoo Linux	Reporter:	Pacho Ramos <pacho>
Component:	Current packages	Assignee:	Jeroen Roovers (RETIRED) <jer>
Status:	RESOLVED WONTFIX
Severity:	enhancement
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	opera-9.51-no_md5check.patch

Description Pacho Ramos gentoo-dev

2008-09-07 12:14:44 UTC

Currently opera's installer runs a md5check that always fails because ebuild modifies a file, this is why following einfo is being used:
einfo "It is safe to ignore warnings about failed checksums"

The attached patch prevents installer from running this unneded md5check, then, this einfo can be dropped


Reproducible: Always

Comment 1 Pacho Ramos gentoo-dev

2008-09-07 12:15:15 UTC

Created attachment 164808 [details, diff]
opera-9.51-no_md5check.patch

It also works fine with opera-9.52

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2008-09-08 15:11:40 UTC

Sorry, I simply have to vote NO on this one. Fixing install.sh will always be messy, and fixing trivial issues like this one (heck, we KNOW we changed the file, don't we? :) isn't going to improve maintenance in the long run. Let's focus on the other install.sh bugs in order to 1) improve maintenance by applying minimal patching and 2) fix real bugs.

Comment 3 Pacho Ramos gentoo-dev

2008-09-08 16:25:39 UTC

Are you sure that this will change a lot with new opera releases? Patch simply removes a line (sed could be used also for this if you prefer...)