Bug 236945

Summary:	layman-1.2.0 deletes existing directory when adding git overlay
Product:	Gentoo Linux	Reporter:	tao
Component:	[OLD] Unspecified	Assignee:	Gunnar Wrobel (RETIRED) <wrobel>
Status:	RESOLVED FIXED
Severity:	major
Priority:	High
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---

Description tao 2008-09-07 11:39:11 UTC

When adding git overlay and target directory already exist, layman exits with failure but it deletes this target directory. This behavior is different from eg. svn type overlays, where target directory is kept intact.

Reproducible: Always

Steps to Reproduce:
1. mkdir dir with git-overlay name (e.g. zen-overlay) in layman overlay dir and fill it with data
2. layman -L && layman -a zen-overlay

Actual Results:  
layman fails with:

* Running command "/usr/bin/git clone "git://zen-sources.org/zen/portage-overlay.git/" "/usr/portage/local/zen-overlay""...
fatal: destination directory '/usr/portage/local/zen-overlay' already exists.
* Failed to add overlay "zen-overlay".
* Error was: Adding the overlay failed!

and zen-overlay directory is removed completely.

Expected Results:  
layman aborting with failure message while keeping zen-overlay directory intact

Comment 1 Gunnar Wrobel (RETIRED) gentoo-dev

2008-11-15 10:34:08 UTC

Fixed in layman-1.2.1. Available via portage.