Summary: | Klamav doesn't build against new clamav-0.94 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Billy DeVincentis <billydv1> |
Component: | Current packages | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | j0inty, th0br0 |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 236665 | ||
Attachments: |
updated klamav-0.44 ebuild
patch for klamav 0.44 clamav 0.94 compability fixed clamav 0.94 patch klamav-0.44.ebuild diff Mandriva klamav 0.44 patch |
Description
Billy DeVincentis
2008-09-06 06:45:33 UTC
Created attachment 164687 [details]
updated klamav-0.44 ebuild
Created attachment 164689 [details]
patch for klamav 0.44 clamav 0.94 compability
EBuild & Patch tested on x86
Hi, I would don't use this patch. !!!! You remove a return statement and the function will not stop here anymore !!!! Try to find the needed include statement, but don't remove a return. j0inty Created attachment 164709 [details]
fixed clamav 0.94 patch
tested on x86
Created attachment 164711 [details]
klamav-0.44.ebuild diff
(In reply to comment #4) > fixed clamav 0.94 patch Andreas, where did you get that patch from? Or did you make it yourself? We are currently wondering if simply replacing the return value is the right way to go. Created attachment 164733 [details]
Mandriva klamav 0.44 patch
While first googling for a possible patch for this, I found this mandriva patch (from klamav-0.44-2mdv2009.0.src.rpm). As you can see in the patch, they are totally removing the check function if the fd is valid.
As such behaviour can lead to problems - as far as I know fd - I decided just to replace the return value.
(In reply to comment #7) > Created an attachment (id=164733) [edit] > Mandriva klamav 0.44 patch > > While first googling for a possible patch for this, I found this mandriva patch > (from klamav-0.44-2mdv2009.0.src.rpm). As you can see in the patch, they are > totally removing the check function if the fd is valid. > As such behaviour can lead to problems - as far as I know fd - I decided just > to replace the return value. > OK, thanks for the info. Meanwhile, we investigated this issue. fsync() calls were completely removed in clamav, that's why the CL_EFSYNC return value was no longer needed. The mandriva patch looks similar to the changes clamav applied to their code[1]. However, jmbsvicetto figured out, that the return value actually isn't used after the function returns, so replacing it shouldn't be a problem. For future reference: Furthermore, we contacted klamav upstream which is preparing a new release, but it agreed that replacing the return value for now is a possible solution. Thanks for the patch! Just committed to CVS. [1] http://svn.clamav.net/websvn/diff.php?repname=clamav-devel&path=%2Ftrunk%2Flibclamav%2Fscanners.c&rev=3728&sc=1 |