Bug 236489

Summary:	media-gfx/fbv-1.0b - gentoo-x86/media-gfx/fbv/files/oob-segfault-fbv-1.0b.diff improvements
Product:	Gentoo Linux	Reporter:	kent yogi <kent>
Component:	New packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED NEEDINFO
Severity:	normal	CC:	pierre42d
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description kent yogi 2008-09-02 19:40:16 UTC

media-gfx/fbv has wrong patch file like below.
-    blit2FB(fh, fbbuff, alpha, x_size, y_size, x_stride, var.yres_virtual, x_pa
+    blit2FB(fh, fbbuff, alpha, x_size, y_size, x_stride, var.yres, x_pan, y_pan

7th arg of blit2FB function should be var.yres_virtual,
but this patch modified wrong value var.yres.

if you want to reduce memory mapping size, you also have to modify mmap's offset argument in blit2FB function to var.yoffset maybe.

now, this program abend on framebuffer console which have ywrap option.

forgive my poor english, thank you.

Reproducible: Always

Comment 1 Pacho Ramos gentoo-dev

2012-02-12 11:39:47 UTC

But, what problems are currently suffering without applying this change?

Comment 2 Robin Johnson archtester

2012-02-12 19:53:12 UTC

@pacho: the user's email account bounced.