Bug 235785 – please keyword mail-mta/exim ~x86-fbsd

• Product: Gentoo/Alt
• Status: RESOLVED FIXED

[Description Dmitri Bogomolov 2008-08-26 13:41:22 UTC]

I recently have built mail-mta/exim-4.69 with
USE="-perl dnsdb exiscan exiscan-acl mailwrapper spf syslog"

and this KEYWORDS for dependencies:
net-dialup/radiusclient         x86
mail-filter/libspf2             x86

there are 2 issues:
a) building build-exim-gentoo/Makefile with gmake
b) no -ldl for DLOPEN_LOCAL_SCAN in src/EDITME

Reproducible: Always




I prefer to make attachment here..

[Comment 1 Dmitri Bogomolov 2008-08-26 13:46:00 UTC]

Created attachment 163813 [details, diff]
This one edited for conditional -ldl

Only one condition in first snippet

[Comment 2 Dmitri Bogomolov 2008-08-26 13:47:15 UTC]

Created attachment 163815 [details, diff]
gmake style .if/.endif condition to make with gmake

[Comment 3 Dmitri Bogomolov 2009-03-26 09:40:58 UTC]

Created attachment 186309 [details]
updated ebuild with conditional epatch

[Comment 4 Fabian Groffen 2009-07-02 18:47:06 UTC]

Your gmake patch will never break anything on Gentoo (not even Gentoo Prefix on vanilla FreeBSD), so you don't have to apply it conditionally.

Have you brought your dlopen-patch upstream yet?

[Comment 5 Dmitri Bogomolov 2009-08-01 15:46:00 UTC]

Created attachment 199814 [details, diff]
difference from original dlopen patch

(In reply to comment #4)
> Have you brought your dlopen-patch upstream yet?
> 
No, this is a gentoo patch. I just made trivial change - ldl only for Linux.

[Comment 6 Fabian Groffen 2009-08-01 15:48:48 UTC]

What patches are still relevant here?  Is this latest patch all you need to be applied?

[Comment 7 Dmitri Bogomolov 2009-08-01 15:56:45 UTC]

(In reply to comment #6)
> What patches are still relevant here?  Is this latest patch all you need to be
> applied?
> 

:) I need to apply this patch to patch that in tree.

[Comment 8 Dmitri Bogomolov 2011-02-08 20:10:40 UTC]

Created attachment 261867 [details]
ebuild for newer exim

I choosed another approach for mail-mta/exim-4.72-r2: MAKE=make for fbsd.

[Comment 9 Dmitri Bogomolov 2011-02-08 20:12:21 UTC]

Created attachment 261869 [details, diff]
dlopen patch for use with bsd make

Replaced if ; then ; fi with .if .endif

[Comment 10 Fabian Groffen 2011-02-08 20:13:36 UTC]

(In reply to comment #8)
> Created an attachment (id=261867) [details]
> ebuild for newer exim
> 
> I choosed another approach for mail-mta/exim-4.72-r2: MAKE=make for fbsd.


Thanks!  Can you please attach a diff -u of your ebuild agains the original one
from Gentoo?  Would help me to spot the differences.

[Comment 11 Dmitri Bogomolov 2011-02-08 20:16:32 UTC]

Created attachment 261871 [details, diff]
difference from original dlopen patch

Excuse me please my fickleness

[Comment 12 Dmitri Bogomolov 2011-02-08 20:19:11 UTC]

Created attachment 261873 [details, diff]
difference from exim-4.72-r1.ebuild

Here the diff -u

[Comment 13 Fabian Groffen 2011-02-08 20:29:25 UTC]

(In reply to comment #12)
> Created an attachment (id=261873) [details]
> difference from exim-4.72-r1.ebuild
> 
> Here the diff -u

- I believe the dlopen patch can be actually a single patch (it has the conditional in the makefile)
- why do you need the MAKE=make?
- why can't we install logrotate files on FreeBSD?

[Comment 14 Dmitri Bogomolov 2011-02-08 22:19:25 UTC]

(In reply to comment #13)

> - why do you need the MAKE=make?
I can't write patch for mgake anymore.

> - why can't we install logrotate files on FreeBSD?

We can. And many packages installs: I have it from openrc, clamav, nginx, rsync. But I believe logrotate unneeded on fbsd: there is the newsyslog in sys-freebsd/freebsd-usbin.

[Comment 15 Fabian Groffen 2011-02-09 09:54:05 UTC]

(In reply to comment #14)
> > - why do you need the MAKE=make?
> I can't write patch for mgake anymore.

I don't see how gmake can make a problem here.  Can you perhaps show me a build failure when gmake is used?
 
> > - why can't we install logrotate files on FreeBSD?
> 
> We can. And many packages installs: I have it from openrc, clamav, nginx,
> rsync. But I believe logrotate unneeded on fbsd: there is the newsyslog in
> sys-freebsd/freebsd-usbin.

Ok, so that freebsd conditional is unnecessary.  If logrotate stuff is useless on fbsd, it should just remove this through bashrc in the profiles.

[Comment 16 Dmitri Bogomolov 2011-02-09 13:09:34 UTC]

Created attachment 261909 [details]
Build failure for =mail-mta/exim-4.72-r1

[Comment 17 Dmitri Bogomolov 2011-02-09 13:15:01 UTC]

(In reply to comment #15)

> I don't see how gmake can make a problem here.  Can you perhaps show me a build
> failure when gmake is used?
> 

from /tmp/portage/mail-mta/exim-4.72-r1/work/exim-4.72/build-exim-gentoo/Makefile:

# From OS/Makefile-FreeBSD
PORTOBJFORMAT!= test -x /usr/bin/objformat && /usr/bin/objformat || echo aout
CHOWN_COMMAND=/usr/sbin/chown
STRIP_COMMAND=/usr/bin/strip
CHMOD_COMMAND=/bin/chmod
HAVE_SA_LEN=YES
LIBS=-lcrypt -lm -lutil
USE_DB=yes
.ifdef   X11BASE
^ Makefile:40, mentioned in https://bugs.gentoo.org/attachment.cgi?id=261909

> 
> Ok, so that freebsd conditional is unnecessary.  If logrotate stuff is useless
> on fbsd, it should just remove this through bashrc in the profiles.
> 
I don't know how to do this.

[Comment 18 Fabian Groffen 2011-02-09 13:17:32 UTC]

yeah, I need to make sure it doesn't use that FreeBSD Makefile, because it also defines different defaults than what the ebuild assumes/writes.

[Comment 19 Dmitri Bogomolov 2011-02-11 05:22:21 UTC]

(In reply to comment #15)

> Ok, so that freebsd conditional is unnecessary.  If logrotate stuff is useless
> on fbsd, it should just remove this through bashrc in the profiles.
> 

Maybe I don't understand the message. Look at ebuild for net-proxy/squid-2.7.9 in tree:

IUSE="logrotate"
DEPEND="!x86-fbsd? ( logrotate? ( app-admin/logrotate ) )"

Do you think it acceptable for mail-mta/exim to use something like this?

[Comment 20 Fabian Groffen 2011-02-11 09:46:15 UTC]

I don't think exim is depending on logrotate.  My point is that we decided some time back ago that we would just unconditionally install logrotate files, since they are just extra files that don't harm anyone when installed but unused.

So, if FreeBSD doesn't have logrotate, we can still install these files according to the global decision made (as above).  Of course it is ok to conditionally depend on logrotate if Gentoo/FreeBSD doesn't have it, but I don't think the exim ebuild does this at the moment.

[Comment 21 Dmitri Bogomolov 2011-02-13 11:36:04 UTC]

Created attachment 262335 [details]
mail-mta/exim-4.72 ebuild with logrotate USE-flag

I have added `logrotate` to IUSE to choose whenever to install logrotate staff like in other ebuilds (squid for example), because one may choose to use logrotate on FreeBSD, but other - to not use it on Linux.

Any way I think this better than userland_BSD.

[Comment 22 Dmitri Bogomolov 2011-02-13 11:36:48 UTC]

Created attachment 262337 [details, diff]
difference from exim-4.72-r1.ebuild

[Comment 23 Fabian Groffen 2011-02-13 20:34:03 UTC]

Can you please try and see if 4.74-r2 builds for you?  If so, I'll keyword it.

[Comment 24 Dmitri Bogomolov 2011-02-14 18:51:29 UTC]

Created attachment 262507 [details]
build.log for =mail-mta/exim-4.74-r2 on g/fbsd-8.0

[Comment 25 Dmitri Bogomolov 2011-02-14 18:53:41 UTC]

Created attachment 262509 [details]
emerge --info on my g/fbsd-8.0 installation

[Comment 26 Fabian Groffen 2011-05-08 09:29:43 UTC]

I just checked in a fix for building on FreeBSD (confirmed on Gentoo Prefix on FreeBSD 8.2).

[Comment 27 Dmitri Bogomolov 2011-05-08 11:24:24 UTC]

Created attachment 272475 [details]
build.log for =mail-mta/exim-4.75-r1 on linux

I can't install =mail-mta/exim-4.75-r1 on linux.

[Comment 28 Fabian Groffen 2011-05-08 14:38:06 UTC]

your buildlog shows you're trying 4.74-r2, not 4.75-r1.  And I don't understand what you mean with "on linux", as your buildlog clearly identifies your system as freebsd8.0

[Comment 29 Dmitri Bogomolov 2011-05-08 14:44:03 UTC]

Created attachment 272487 [details]
build.log for =mail-mta/exim-4.75-r1 on linux

Excuse me. This is the right build.log for linux.

I confirm that =mail-mta/exim-4.75-r1 successfully install on g/fbsd-8.0.

[Comment 30 Dmitri Bogomolov 2011-05-08 15:09:27 UTC]

BTW: I see no ~x86-fbsd use-flag in exim-4.75-r1.ebuild in tree.

[Comment 31 Fabian Groffen 2011-05-08 15:11:11 UTC]

keyword is bug for freebsd guys.

psql build problem is a separate issue

[Comment 32 Fabian Groffen 2011-05-08 15:12:46 UTC]

I did my job here

[Comment 33 Dmitri Bogomolov 2011-05-08 20:35:02 UTC]

(In reply to comment #31)

> psql build problem is a separate issue

OK, that is in bug 366501.

[Comment 34 Dmitri Bogomolov 2011-07-05 06:07:53 UTC]

Any chance to have ~x86-fbsd keyword in newer exim ebuilds?

[Comment 35 Naohiro Aota 2013-12-30 08:09:53 UTC]

Finally ~x86-fbsd was added to the ebuild.