| Summary: | linux-mod.eclass: update-modules doesn't appear to be called | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Richard Westwell <garlicbread> |
| Component: | Eclasses | Assignee: | Gentoo Kernel Bug Wranglers and Kernel Maintainers <kernel> |
| Status: | RESOLVED TEST-REQUEST | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | 2007.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | patch for linux-mod.eclass | ||
Created attachment 163621 [details, diff]
patch for linux-mod.eclass
Patch looks good, thanks! Have you tested it? |
I'm not sure but I think I might have spotted a bug within linux-mod.eclass where update-modules is not getting called during the normal emerge process for a kernel module first there's a check within linux-mod_pkg_preinst() to see if certain directories exist i.e. [ -d "${D}etc/modules.d" ] && UPDATE_MODULES=true || UPDATE_MODULES=false this is okay so far next within linux-mod_pkg_postinst() the update_modules function is called ${UPDATE_MODULES} && update_modules; still okay However when we get to the update_modules function it seems to be checking for the presence of files with content within the install destination directory the command "grep -v -e "^#" -e "^$" ${D}/etc/modules.d/* >/dev/null 2>&1" doesn't find anything as the ${D} image directory is now empty (within /var/tmp/portage), as we're now in post-install rather than pre-install attached is a suggested patch Reproducible: Always Steps to Reproduce: 1. emerge any kernel module ebuild that ues linux-mod and places files within /etc/modules.d/ 2. 3.