Summary: | net-print/gnome-cups-manager-0.33 mixes CFLAGS and CXXFLAGS | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | New packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | printing |
Priority: | High | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 234011 | ||
Attachments: | Build log |
Description
Diego Elio Pettenò (RETIRED)
2008-08-05 22:07:48 UTC
Created attachment 162320 [details]
Build log
Diego, I like all the QA work you're doing, I really do, it's great and it's pushing FOSS further... but your bug reports are _horrible_. I just have _no_ fricking clue what's wrong. No idea what to look for, no example, no nothing. So please, help us help you, don't open obscure bug reports that only mean something to you. Thanks :) (In reply to comment #2) CFLAGS shouldn't be used for compilation of C++ files. You should fix Makefiles (or other files) to use CXXFLAGS for compilation of C++ files. Easy explanation (tomorrow there should be a post in my blog about this): there is some Makefile in the package that is building C++ code setting, inside _CXXFLAGS, the value of user's CFLAGS. It should be fixed so that CXXFLAGS is used instead, as the two variables are well separated. +*gnome-cups-manager-0.33-r2 (29 Aug 2010) + + 29 Aug 2010; Gilles Dartiguelongue <eva@gentoo.org> + +gnome-cups-manager-0.33-r2.ebuild, + +files/gnome-cups-manager-0.33-automagic-samba.patch, + +files/gnome-cups-manager-0.33-cxxflags-separation.patch: + Do not add CFLAGS to CXXFLAGS, bug #234028. Fix automagic samba support, + bug #288392. + Problem was that package was defining CFLAGS in INCLUDES, so it's now patched to separate flags in CFLAGS/CXXFLAGS/CPPFLAGS. |