Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 233523

Summary: media-sound/skype-call-recorder-0.8 (new package)
Product: Gentoo Linux Reporter: jlh
Component: New packagesAssignee: Default Assignee for New Packages <maintainer-wanted>
Status: RESOLVED FIXED    
Severity: enhancement CC: dark.knight.ita, denilsonsa, gef.kornflakes, mmokrejs, reavertm, serkan, Thomas.Rausch
Priority: High Keywords: EBUILD, InVCS
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://atdot.ch/scr/
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Ebuild for Skype Call Recorder
EAPI-2, fixed ebuild, new version bump
Improved ebuild (respects CXXFLAGS, repoman is happy, use cmake eclass correctly, etc)

Description jlh 2008-07-31 20:09:01 UTC
Skype Call Recorder is a small and simple tool to record Skype calls to MP3/Ogg/WAV files.  Find attached an ebuild for it.

Two remaining issues:
(1) I'm unsure about which category to put this in.  I've chosen app-misc/skype-call-recorder for now, but I will welcome better suggestions.
(2) It depends on cmake-2.4.8 which is currently still ~x86.

I don't know if this ebuild would be welcome in the official tree, or if maybe an overlay (sunrise?) is a better choice.  In any case I'd volunteer to maintain it if nobody else wants to (which makes sense, since I'm the author of this program).

--jlh
Comment 1 jlh 2008-07-31 20:10:07 UTC
Created attachment 161874 [details]
Ebuild for Skype Call Recorder
Comment 2 Wormo (RETIRED) gentoo-dev 2008-07-31 21:54:57 UTC
Submitting to sunrise first sounds like a good idea. The reviewers there may suggest another category.

http://overlays.gentoo.org/proj/sunrise/wiki/HowToCommit
Comment 3 jlh 2008-07-31 23:31:46 UTC
Will do, thanks.
Comment 4 Carsten Lohrke (RETIRED) gentoo-dev 2008-08-01 09:30:12 UTC
@Wormo: New package assignee is maintainer-wanted. maintainer-needed is for packages already in the Gentoo repository nobody cares for. Also the keywords field should be set either to EBUILD or REQUEST.


@jlh: x11-libs/qt dependency is not correct, see bug 217161 comment 11.
Comment 5 jlh 2008-08-01 12:51:15 UTC
Oh I see, thanks.  I'm changing to this:

|| (
    ( >=x11-libs/qt-gui-4.3.0:4 >=x11-libs/qt-dbus-4.3.0:4 )
    =x11-libs/qt-4.3*:4
)
Comment 6 jlh 2008-08-12 00:51:05 UTC
This is now in the sunrise overlay.  You can find it here:
http://overlays.gentoo.org/svn/proj/sunrise/reviewed/media-sound/skype-call-recorder
Comment 7 Maciej Mrozowski gentoo-dev 2009-03-18 21:23:44 UTC
Created attachment 185464 [details]
EAPI-2, fixed ebuild, new version bump

have fun - it obsoletes the one from sunrise - I could proxy maintain it if someone is willing to push it to tree
Comment 8 jlh 2009-03-18 22:31:32 UTC
(In reply to comment #7)
> EAPI-2

Huh?  The sunrise version already uses EAPI-2.

> fixed ebuild

You should explain what you fixed.  What's better now?  And why did you remove some of the stuff, like the dependency on the cmake 2.4.8 (earlier version do not work), or the warning about static qt?  Or has that issue been resolved on amd64?  The qt-4.3 stuff can be removed as you did, I guess, since qt 4.3 is masked by now.

> new version bump

Yeah, I neglected to update from 0.7 to 0.8, but the difference between them is very minimal.

Also, this ebuild might change its name...  Skype is not happy that I use the word 'Skype' like that in the program's name.
Comment 9 Maciej Mrozowski gentoo-dev 2009-05-19 23:05:21 UTC
Damn, forgot to add myself to CC...
About cmake - 2.6.2 is stable on most archs now, so no need to pull cmake dependencies.
About that removed warning, maybe it's worth re-adding, but still it needs tweaks as your application works well on x86_64 (and I added keywords), just needs manually downloaded dynamically linked Skype version (the one with dbus support) and manually built 32bit Qt4 libs.
Still it's all correct as skype is not in RDEPEND (so just needs any skype), and it will be added there only when qt4 ebuilds support true multilib.
When multilib issues are resolved, I'll probably take this ebuild to qting-edge (Gentoo Qt team overlay), add proper skype deps and babysit ebuild there, as from there, there's short way to the tree.
Comment 10 Maciej Mrozowski gentoo-dev 2009-05-19 23:12:22 UTC
Forgot to add, about "fixed ebuild" - I mean fixed Qt deps a bit (added qt-dbus, removed dbus), and Qt moved deps to split ebuilds dropping those no longer in tree (4.3).
Comment 11 jlh 2009-06-01 10:10:26 UTC
(In reply to comment #9)
> About cmake - 2.6.2 is stable on most archs now, so no need to pull cmake
> dependencies.

Agreed, since cmake-utils pulls it in already.

> When multilib issues are resolved, I'll probably take this ebuild to qting-edge (Gentoo Qt team overlay), add proper skype deps and babysit ebuild there, as from there, there's short way to the tree.

Is there anything wrong with this ebuild being in sunrise?  And I don't think it's the right thing to do, to make this depend on Skype.  SCR does work without Skype, you just can't record any calls, obviously.
Comment 12 Nico Schlömer 2009-06-18 13:46:02 UTC
Hi,

say, can't we make use of the new EAPI here and demand net-im/skype to be installed with the qt-static flag disabled? Or would that be impossible as skype really isn't a dependency of this one?

At least, I guess, we should insert an einfo about this.

Cheers,
Nico
Comment 13 Markos Chandras (RETIRED) gentoo-dev 2010-01-12 20:05:04 UTC
qt-static on skype is forced on x86 profiles  but this package requires -qt-static on skype. I had to masked this package due to this issue. Please fix it
Comment 14 jlh 2010-01-12 20:31:37 UTC
Aww, now that emul-linux-x86-qtlibs on amd64 will finally start to install Qt4 to be able to remove the forced qt-static on amd64, it's now getting forced again for different reasons.  Quite annoying.  But I understand the reasons of course.  Let's hope Skype fixes this issue before they go stable with the next version. Nothing else that can be done otherwise, I think, since this package cannot work with a static Skype.
Comment 15 Martin Mokrejš 2010-10-13 08:01:11 UTC
What is the current status of this bug? I think I remember there were proposals to remove it from the tree, and, indeed, I cannot find it anymore in sunrise overlay. I only have it in my own ebuilds. It does build fine for me, see below.
What is going on?

# layman -S
* Running... # ( cd /var/lib/layman/science  && /usr/bin/git pull )
Already up-to-date.
* Running... # /usr/bin/svn up /var/lib/layman/sunrise
At revision 11422.
* 
* Success:
* ------
* 
* Successfully synchronized overlay "science".
* Successfully synchronized overlay "sunrise".
# find /usr/local/portage/ -name skype*
/usr/local/portage/media-sound/skype-call-recorder
/usr/local/portage/media-sound/skype-call-recorder/skype-call-recorder-0.8.ebuild
#

I use it on ~x86:

# emerge -pv skype skype-call-recorder

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R   ] media-sound/skype-call-recorder-0.8  USE="-debug" 0 kB [?=>1]
[ebuild   R   ] net-im/skype-2.1.0.81  USE="-qt-static" 0 kB [0]
Comment 16 jlh 2010-10-13 11:31:26 UTC
(In reply to comment #15)
> What is the current status of this bug? I think I remember there were proposals
> to remove it from the tree, and, indeed, I cannot find it anymore in sunrise
> overlay.

Where did you see proposals to remove it?  I still appear to have it in my sunrise tree, although version 0.7.

And for some reason it doesn't compile, but I'm unsure whether maybe my system is currently broken, because it doesn't even ever call "cmake".

This package was once masked, because it requires -qt-static on skype, and qt-static was forced on skype a while back, so skype-call-recorder would not work. That forced qt-static on skype has apparently been removed in the meantime, so there's no reason why skype-call-recorder should still be masked I guess.

I'm at work right now, but I need to look further into it.
Comment 17 Martin Mokrejš 2010-10-13 18:10:39 UTC
(In reply to comment #16)
> (In reply to comment #15)
> > What is the current status of this bug? I think I remember there were proposals
> > to remove it from the tree, and, indeed, I cannot find it anymore in sunrise
> > overlay.
> 
> Where did you see proposals to remove it?  I still appear to have it in my
> sunrise tree, although version 0.7.

I think it was scheduled for removal from the tree, and it bumped on me when emerge was started. I think, but maybe be wrong.

> 
> And for some reason it doesn't compile, but I'm unsure whether maybe my system
> is currently broken, because it doesn't even ever call "cmake".


Yes, I also had to "fix" it for myself for 0.7. Had to add src_compile() to call "cmake ." and src_install() to call "emake install DESTDIR=....' variable to it. For 0.8 I do not need it. probably due to the EAPI2 vs. 3.

 
> This package was once masked, because it requires -qt-static on skype, and
> qt-static was forced on skype a while back, so skype-call-recorder would not
> work. That forced qt-static on skype has apparently been removed in the
> meantime, so there's no reason why skype-call-recorder should still be masked > I guess.
> 
> I'm at work right now, but I need to look further into it.

Great, thanks for explanation, I do not need any new fancy skype with more camera drivers, I just want voice and recording. So, any skype version would do for me.
Comment 18 tman 2011-05-29 07:23:22 UTC
could some one bake a life ebuild for it? ther is something fixed after the last offical package 0.8: 

http://repo.or.cz/w/skype-call-recorder.git
Comment 19 Gef 2011-07-22 22:50:37 UTC
Created attachment 280683 [details]
Improved ebuild (respects CXXFLAGS, repoman is happy, use cmake eclass correctly, etc)

Please find attached ebuild. Compiles and merges fine. Repoman likes it.
App untested below configuration window.

Feel free to review.
Comment 20 Maciej Mrozowski gentoo-dev 2011-07-23 12:51:40 UTC
(In reply to comment #19)
> Created attachment 280683 [details]
> Improved ebuild (respects CXXFLAGS, repoman is happy, use cmake eclass
> correctly, etc)
> 
> Please find attached ebuild. Compiles and merges fine. Repoman likes it.
> App untested below configuration window.
> 
> Feel free to review.

- inherit eutils is not necessary (not used)
- appending -DCMAKE_VERBOSE_MAKEFILE=TRUE is not recommended, compilation process verbosity level should not be hardcoded in ebuilds
- overriding src_configure, src_compile and src_install is not needed at all in this case

Ok, this bug is getting a bit ridiculous, I'll add this package to tree.
Comment 21 Gef 2011-07-23 20:30:25 UTC
(In reply to comment #20)
> (In reply to comment #19)
> - inherit eutils is not necessary (not used)
> - appending -DCMAKE_VERBOSE_MAKEFILE=TRUE is not recommended, compilation
> process verbosity level should not be hardcoded in ebuilds
> - overriding src_configure, src_compile and src_install is not needed at all in
> this case
> 
> Ok, this bug is getting a bit ridiculous, I'll add this package to tree.

Thanks for taking the time to review and commit improved version (interesting patch to CMakeLists.txt btw). Took good notes of your advises, thanks.

I actually took the idea of the hardcoded verbose cmake from hedgewars-0.9.15.ebuild while I was trying to have cmake respect the cxxflags.