Summary: | LDFLAGS used for Module-Build packages are LDFLAGS from dev-lang/perl | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Torsten Veller (RETIRED) <tove> |
Component: | Eclasses | Assignee: | Gentoo Perl team <perl> |
Status: | RESOLVED DUPLICATE | ||
Severity: | normal | CC: | binki, darkside, dilfridge, esigra, flameeyes, jer, kdvgent, pesa, robert.wohlrab, vincent, xarthisius |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://tinderbox.x86.dev.gentoo.org/misc/dindex/virtual/perl-Module-Build | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 264155, 264186, 308629 | ||
Bug Blocks: | 239510, 331933 | ||
Attachments: |
perl-module.eclass-LDFLAGS.patch
adding OTHERLDFLAGS during install phase |
Description
Torsten Veller (RETIRED)
2008-07-30 07:36:05 UTC
+1. Created attachment 165151 [details, diff]
perl-module.eclass-LDFLAGS.patch
Patch based on Tove's suggestion.
I'm getting the "QA Notice: Files built without respecting LDFLAGS have been detected" message from several perl modules. Arfrever: is your patch supposed to fix these warnings? (In reply to comment #3) > I'm getting the "QA Notice: Files built without respecting LDFLAGS have been > detected" message from several perl modules. > Arfrever: is your patch supposed to fix these warnings? This patch fixes these warnings only in a part of Perl modules. tove: Think we can do this now, it is pretty trivial and will help with many packages. When this gets added can the packages affected be bumped so that they will actually get reinstalled (and thereby no longer be affected by the issue)? *** Bug 250724 has been marked as a duplicate of this bug. *** *** Bug 250726 has been marked as a duplicate of this bug. *** *** Bug 250727 has been marked as a duplicate of this bug. *** *** Bug 250730 has been marked as a duplicate of this bug. *** *** Bug 250732 has been marked as a duplicate of this bug. *** *** Bug 250734 has been marked as a duplicate of this bug. *** Fixed. --extra_linker_flags doesn't work for Module::Build distributions. It replaces the settings in Build.PL. So can we do now? Created attachment 232721 [details, diff]
adding OTHERLDFLAGS during install phase
OTHERLDFLAGS should also be used in src_install. I've found at least one pkg that needs it:
emerge -1 =dev-perl/perl-tk-804.028-r3
* QA Notice: Files built without respecting LDFLAGS have been detected
* Please include the following list of files in your report:
* /usr/lib64/perl5/vendor_perl/5.10.1/x86_64-linux/auto/Tk/Tk.so
(In reply to comment #15) > OTHERLDFLAGS should also be used in src_install. I've found at least one pkg > that needs it: > > emerge -1 =dev-perl/perl-tk-804.028-r3 Try with MAKEOPTS=-j1. Looks like a parallel make issue. (In reply to comment #16) > Try with MAKEOPTS=-j1. Looks like a parallel make issue. Parallel build issue it is... Sorry for the noise *** Bug 332835 has been marked as a duplicate of this bug. *** *** Bug 333049 has been marked as a duplicate of this bug. *** Only Module-Build packages [0] ignore LDFLAGS. All others work (but they might not know it yet). [0] http://tinderbox.x86.dev.gentoo.org/misc/dindex/virtual/perl-Module-Build Things changed: dev-lang/perl-5.12.2-r1 respects LDFLAGS. Furthermore it records and uses its ldflags, lddlflags (see perl -V) later on for building modules. It still doesn't use the LDFLAGS from env for Module-Build modules but the recorded perl LDFLAGS. So it's the same as bug 236200. bug 308629: app-pda/pilot-link uses OTHERLDFLAGS in Makefile.PL which are replaced by setting OTHERLDFLAGS in perl-module.eclass. So neither OTHERLDFLAGS for ExtUtils::MakeMaker nor --extra_linker_flags for Module::Build distributions works reliably. We are still looking for a correct way to pass LDFLAGS, CFLAGS (bug #261375, bug #236200 ) ,... *** Bug 451104 has been marked as a duplicate of this bug. *** Upstream is working on it. Deferred for EAPI=7 *** This bug has been marked as a duplicate of bug 261375 *** |