Bug 232757

Summary:	gnome-extra/swfdec-gnome-2.22.2, patch to build with --as-needed enabled
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	[OLD] GNOME	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://bugzilla.gnome.org/show_bug.cgi?id=549621
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	129413
Attachments:	swfdec-gnome-2.22.2-asneeded.patch

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-07-23 14:45:04 UTC

The attached patch fixes building with --as-needed in LDFLAGS. Upstream probably didn't know how to properly use automake, the libraries were passed through LDFLAGS that is not correct.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2008-07-23 14:45:23 UTC

Created attachment 161193 [details, diff]
swfdec-gnome-2.22.2-asneeded.patch

Comment 2 Nguyen Thai Ngoc Duy (RETIRED) gentoo-dev

2008-07-23 15:05:38 UTC

I'm being retired now. Gnome herd should take care of this, or you commit yourself.

Comment 3 Daniel Gryniewicz (RETIRED) gentoo-dev

2008-07-23 19:54:58 UTC

I can see that's wrong, but it builds fine for me with --as-needed.  What's up with that?

Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev

2008-07-23 21:57:06 UTC

libtool reorders the parameter so by default you won't see the failure. I'm testing with a slightly more aggressive setup and it fails :)

Comment 5 Mart Raudsepp gentoo-dev

2008-08-04 09:31:42 UTC

The patch looks obviously correct on its own merit. Makes it follow what automake manual says is supposed to be done

Comment 6 Rémi Cardona (RETIRED) gentoo-dev

2008-08-25 11:50:50 UTC

Hum... seeing how Bastien (Nocera) is involved with swfdec-gnome, I suggest you (Diego) open a bug on Gnome's bugzilla to explain directly to them why this patch is a good thing.

I would, of course, commit it in a heart beat as it does the Right Thing (tm) but upstream might need some convincing :)

Comment 7 Diego Elio Pettenò (RETIRED) gentoo-dev

2008-08-27 19:34:22 UTC

As it is the right thing, would you please commit it in the mean time while we wait from upstream? Otherwise I have to keep it modified locally which is boring. Thanks.

At any rate I opened the bug upstream, as I couldn't find Bastien's email at hand.

Comment 8 Gilles Dartiguelongue (RETIRED) gentoo-dev

2009-04-18 10:53:44 UTC

we've been too slow doing anything with this bug but it's in >=2.24 so I guess we can close it now.