| Summary: | net-misc/dropbear savedconfig messes up version string | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Christoph Gysin <christoph.gysin> |
| Component: | Current packages | Assignee: | Daniel Black (RETIRED) <dragonheart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | embedded |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
dragonheart, Maybe some sed logic-love after the config.h is populated? (In reply to comment #1) > dragonheart, Maybe some sed logic-love after the config.h is populated? > Sure. I've just emailed the upstream author for his opinion and plans. Thanks Christoph for highlighting these deficiencies. this is fixed with 0.52 ... upstream moved these options into sysoptions.h |
The savedconfig useflags makes it possible to use a custom options.h and allows to change some #defines regarding dropbear configuration. Unfortunately, options.h also contains (among other things) the version string DROPBEAR_VERSION. So if one uses savedconfig, the version string will never be updated. Reproducible: Always Steps to Reproduce: 1. USE=savedconfig emerge =net-misc/dropbear-0.50* 2. mv /etc/portage/savedconfig/net-misc/dropbear{-0.50,} 3. USE=savedconfig emerge =net-misc/dropbear-0.51* 4. dropbear -h Actual Results: output: Dropbear sshd v0.50 ... Expected Results: output: Dropbear sshd v0.51 ... In options.h there is a line that says: " * You shouldn't edit below here unless you know you need to." Everything below is lowlevel configuration stuff, and should not be taken from savedconfig. This is a bit messy, and requires an ugly hack with sed & co. Should we try to get the dropbear guys to split options.h, or can is be done in a somehow acceptable manner? TIA