Summary: | media-video/ogmrip-0.12.0 turns warnings into errors | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Paweł Zaskórski <p.zaskorski> |
Component: | New packages | Assignee: | Olivier Rolland <billl> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | CC: | atoth, dark, media-video |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Complete build log
The ebuild environment file Created by "LC_ALL=C emerge ogmrip >/tmp/file.log 2>&1" the patch removes -Werror from CFLAGS in configure ogmrip-0.12.0-aac-ac3-avi.patch ogmrip-0.12.0-r1.ebuild ogmrip-0.12.0-uninitialized.patch ogmrip-0.12.0-r1.ebuild ogmrip-0.12.0-uninitialized.patch ogmrip-0.12.0-undefined.patch ogmrip-0.12.0-r1.ebuild ogmrip-0.12-subp2pgm.patch ogmrip-0.12.0-r1.ebuild |
Description
Paweł Zaskórski
2008-07-02 12:03:23 UTC
Created attachment 159311 [details]
Complete build log
Created attachment 159313 [details]
The ebuild environment file
Maybe there's a configure option to not set -Werror? :) I don't see any warning in your log file. Perhaps you forgot to redirect the error output. build.log is a standard log file created by portage. Should I build this package with some extra options for additional error output? I know build.log is a standard log file created by portage. But I can't find the compilation error in this file. Can you please try emerging ogmrip again with an unlocalized gcc, redirect both standard output and standard error in a single file and post it here ? Thanks, Olivier PS: Just in case, the command line if you're using bash: LC_ALL=C emerge ogmrip > file.log 2>&1 Created attachment 159731 [details]
Created by "LC_ALL=C emerge ogmrip >/tmp/file.log 2>&1"
(In reply to comment #6) > I know build.log is a standard log file created by portage. But I can't find > the compilation error in this file. Can you please try emerging ogmrip again > with an unlocalized gcc, redirect both standard output and standard error in a > single file and post it here ? > > Thanks, > > Olivier Hi Olivier! This is it: cc1: warnings being treated as errors ogmrip-mplayer.c: In function ‘ogmrip_mencoder_container_append_audio_file’: ogmrip-mplayer.c:1002: warning: passing argument 1 of ‘strcpy’ discards qualifiers from pointer target type Dwokfur Created attachment 159762 [details, diff]
the patch removes -Werror from CFLAGS in configure
I suggest you to remove Werror flag from release versions of ogmrip. Please take a look at the attached patch.
Regards,
Dw.
(In reply to comment #9) > Created an attachment (id=159762) [edit] > the patch removes -Werror from CFLAGS in configure > > I suggest you to remove Werror flag from release versions of ogmrip. Please > take a look at the attached patch. > > Regards, > Dw. > Either you inherit flag-o-matic and do filter-flags -Werror or do epatch the above attached diff. Do you want me to create the modified ebuild? Regards, Dw. Thanks for pointing out the problem and providing a patch. However, I don't want to remove -Werror because experience shows that a warning hides more than often an error. And after looking at the code, I think there is actually a bug. I'll provide a patch ASAP. Regards, Olivier Created attachment 159841 [details, diff]
ogmrip-0.12.0-aac-ac3-avi.patch
This patch fixes some issues when merging an AAC audio stream (or an AC3/DTS audio stream with an old version of mplayer) in an AVI container. It should also fix the compilation issue.
Created attachment 159842 [details]
ogmrip-0.12.0-r1.ebuild
This ebuild applies the patch above.
(In reply to comment #13) > Created an attachment (id=159842) [edit] > ogmrip-0.12.0-r1.ebuild > > This ebuild applies the patch above. > I greatly appreciate your meticulous policy on warnings. This is a crucial step to produce better code. Not so many project could supply their release builds with -Werror enabled. Regards, Dw. Here is an other warning that bails otu as error: ogmrip-video-codec.c: In function 'ogmrip_video_codec_autosize': ogmrip-video-codec.c:573: error: 'scale_height' may be used uninitialized in this function ogmrip-video-codec.c:573: error: 'scale_width' may be used uninitialized in this function Src: guint scale_width, scale_height; ogmrip_video_codec_get_scale_size (video, &scale_width, &scale_height); Although get_scale_size might 'guarantee' scale_width &height are always filled, they should be preinitialized to some sane value. What are your CFLAGS ? CFALGS="-march=nocona -mtune=core2 -O3 -pipe" on ~amd64/2008.0 profile (I did not turn on any -W flags explicitly, if you had that in mind, don't know about the profile though) Created attachment 160278 [details, diff]
ogmrip-0.12.0-uninitialized.patch
This patch should fix your compilation issue (even though the variables are still not initialized in the function). Can you try it and tell me if there are other similar issues ?
Thanks,
Olivier
Created attachment 160280 [details]
ogmrip-0.12.0-r1.ebuild
This ebuild applies all the patches.
Yes, we get a little further, now we end up with: cc1: warnings being treated as errors ogmrip-lavc.c: In function 'ogmrip_lavc_run': ogmrip-lavc.c:128: error: 'predia' may be used uninitialized in this function ogmrip-lavc.c:128: note: 'predia' was declared here ogmrip-lavc.c:128: error: 'dia' may be used uninitialized in this function ogmrip-lavc.c:128: note: 'dia' was declared here BTW: all gcc invocations end in ' >/dev/null 2>&1', which makes it pretty cumbersome to get the errors, because they don'T show up in the build log. I guess, those errors are sent to stdout (not stderr) and that's why they don'T show up in the build log. Can I directly mail you any further patch and only post here when ogmrip compiles cleanly on your system ? Do you need ebuilds to apply the patches ? (In reply to comment #21) > Can I directly mail you any further patch and only post here when ogmrip > compiles cleanly on your system ? Do you need ebuilds to apply the patches ? > Yeah, you can mail the patches directly to my email, I won't need ebuilds, can modify the one I put in my overlay. Created attachment 160288 [details, diff]
ogmrip-0.12.0-uninitialized.patch
This patch should fix all compilation issues with gcc-4.3.
Created attachment 160372 [details, diff]
ogmrip-0.12.0-undefined.patch
This patch fixes some undefined symbols in libogmrip-lavc-option.so
Created attachment 160374 [details]
ogmrip-0.12.0-r1.ebuild
This ebuild applies all the patches.
Dear Olivier, FYI: media-video/ogmrip-0.12.1 fails to compile: cc1: warnings being treated as errors subp2pgm.c: In function ‘load_palette’: subp2pgm.c:404: warning: ignoring return value of ‘fscanf’, declared with attribute warn_unused_result Regards: Dwokfur Created attachment 164079 [details, diff]
ogmrip-0.12-subp2pgm.patch
This patch fixes a compilation error when using the hardened profile.
Created attachment 164080 [details]
ogmrip-0.12.0-r1.ebuild
This ebuild applies the patches above.
dropped the old ebuild from the tree |