Bug 230273

Summary:	x11-drivers/nvidia-drivers-173.14.09 does not respect use flag "custom-cflags"
Product:	Gentoo Linux	Reporter:	boris64 <genzilla>
Component:	New packages	Assignee:	Ricardo Mendoza (RETIRED) <ricmm>
Status:	RESOLVED FIXED
Severity:	minor
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	nvidia-drivers-173.14.09-r1-ebuild.patch

Description boris64 2008-06-30 21:57:39 UTC

x11-drivers/nvidia-drivers-173.14.09 does not respect custom cflags,
because there's a correct path to a Makefile missing in that ebuild.

emerge output (i used version 177.13, but this error seems to be in every ebuild that has "custom-cflags" as use flag:
------------------
...
 * Checking for MTRR support ...                                                                                                                     [ ok ]
 * Checking for Paravirtualized guest support ...
>>> Unpacking source...
Creating directory NVIDIA-Linux-x86_64-177.13-pkg2
Verifying archive integrity... OK
Uncompressing NVIDIA Accelerated Graphics Driver for Linux-x86_64 177.13...........................................................................................................................................
 * Applying NVIDIA_glx-defines.patch ...                                                                                                             [ ok ]
 * Applying NVIDIA_glx-glheader.patch ...                                                                                                            [ ok ]
 * Applying NVIDIA_i2c-hwmon.patch ...                                                                                                               [ ok ]
sed: can't read Makefile.*: Datei oder Verzeichnis nicht gefunden
 * Converting NVIDIA-Linux-x86_64-177.13-pkg2/usr/src/nv/Makefile.kbuild to use M= instead of SUBDIRS= ...                                           [ ok ]
>>> Source unpacked.
...
------------------

As you see, the ebuild tries to patch Makefile.* in ${S}, which doesn't exist.
As an easy workaround it should be enough to use "${NV_SRC}"/Makefile.* here.

I'll attach a patch.

thx in advance ;)

Reproducible: Always

Steps to Reproduce:
1. emerge nvidia-drivers

Comment 1 boris64 2008-06-30 21:59:28 UTC

Created attachment 159027 [details, diff]
nvidia-drivers-173.14.09-r1-ebuild.patch

nvidia-drivers-173.14.09-r1-ebuild.patch

Comment 2 Doug Goldstein (RETIRED) gentoo-dev

2008-12-18 20:53:50 UTC

This has been fixed. Thank you for the report.