Summary: | libgomp from sys-devel/gcc-4.3.1 does not build with certain warning flags in CFLAGS | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Nico R. <n-roeser> |
Component: | [OLD] Core system | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | esigra |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
URL: | http://gcc.gnu.org/PR38436 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Nico R.
2008-06-23 15:22:27 UTC
we're not going to filter any warning flags are you adding the -Werror or is the package ? The package adds -Werror. It must be somewhere in the gcc Makefiles where it calls libgomp/configure, but I haven’t found it yet. Found it: gcc-4.3.1/libgomp/configure.ac contains (starting with line 115): # Add -Wall -Werror if we are using GCC. if test "x$GCC" = "xyes"; then XCFLAGS="$XCFLAGS -Wall -Werror" fi Then, starting from line 230: # Get target configury. . ${srcdir}/configure.tgt CFLAGS="$save_CFLAGS $XCFLAGS" # Check for __sync_val_compare_and_swap, but only after the target has # had a chance to set XCFLAGS. LIBGOMP_CHECK_SYNC_BUILTINS XCFLAGS="$XCFLAGS$XPCFLAGS" AC_SUBST(config_path) AC_SUBST(XCFLAGS) AC_SUBST(XLDFLAGS) # Cleanup and exit. CFLAGS="$save_CFLAGS" This looks bogus to me. Perhaps someone accidentally forgot to remove -Werror from XCFLAGS again or to set XCFLAGS to $save_CFLAGS or something. I don’t quite understand what all this is supposed to do. Anyway, gcc-4.3.1/libgomp/Makefile.am has (line 18): AM_CFLAGS = $(XCFLAGS) This is propagated to Makefile.in, of course, and from there to the final Makefile. It results in LTCOMPILE containing -Werror: XCFLAGS -> AM_CFLAGS -> COMPILE, LTCOMPILE, LINK I assume that gcc-4.3.1/libgomp/configure.ac needs to be fixed. stripping -Werror from the configure is the route we'll take OK, thanks. I have just tested it, works fine. the fix for this will be in gcc-4.3.2-r1 http://sources.gentoo.org/gentoo/src/patchsets/gcc/4.3.2/gentoo/15_all_gcc-libgomp-no-werror.patch?rev=1.1 The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7f16eb5b72bb49fa1dbdedd08ee85b95eaf67cdd commit 7f16eb5b72bb49fa1dbdedd08ee85b95eaf67cdd Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2018-10-27 09:23:45 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2018-10-27 11:46:08 +0000 sys-devel/gcc: cut 1.8 patchset for 6.4.0 Eight new patches: + 103_all_remove-lieee.patch: drop assumed -lieee from -mieee-fp + 104_all_libgfortran-Werror.patch: + 105_all_libgomp-Werror.patch + 106_all_libitm-Werror.patch + 107_all_libatomic-Werror.patch + 108_all_libbacktrace-Werror.patch + 109_all_libsanitizer-libbacktrace-Werror.patch: pull in all -Werror patches from 8.2.0 + 110_all_libstdcxx-no-vtv.patch: drop libvtv RPATH from libstdc++ Bug: https://bugs.gentoo.org/667104 Bug: https://bugs.gentoo.org/475350 Bug: https://bugs.gentoo.org/229059 Bug: http://gcc.gnu.org/PR38436 Bug: https://bugs.gentoo.org/433435 Bug: http://gcc.gnu.org/PR54724 Bug: https://bugs.gentoo.org/582524 Bug: https://gcc.gnu.org/PR85884 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11 sys-devel/gcc/Manifest | 1 + sys-devel/gcc/gcc-6.4.0-r5.ebuild | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2277fa55f1dd056891a5c7037741ee753df8f819 commit 2277fa55f1dd056891a5c7037741ee753df8f819 Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2018-10-27 09:15:23 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2018-10-27 11:46:08 +0000 sys-devel/gcc: cut 1.8 patchset for 7.3.0 Five new patches: + 101_all_remove-lieee.patch: drop assumed -lieee from -mieee-fp + 102_all_libgfortran-Werror.patch: + 103_all_libgomp-Werror.patch + 104_all_libitm-Werror.patch + 105_all_libatomic-Werror.patch + 106_all_libbacktrace-Werror.patch + 107_all_libsanitizer-libbacktrace-Werror.patch: pull in all -Werror patches from 8.2.0 + 108_all_libstdcxx-no-vtv.patch: drop libvtv RPATH from libstdc++ Bug: https://bugs.gentoo.org/667104 Bug: https://bugs.gentoo.org/475350 Bug: https://bugs.gentoo.org/229059 Bug: http://gcc.gnu.org/PR38436 Bug: https://bugs.gentoo.org/433435 Bug: http://gcc.gnu.org/PR54724 Bug: https://bugs.gentoo.org/582524 Bug: https://gcc.gnu.org/PR85884 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11 sys-devel/gcc/Manifest | 1 + sys-devel/gcc/gcc-7.3.0-r6.ebuild | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c84f250076a6a6f33202c022a256b34284d91111 commit c84f250076a6a6f33202c022a256b34284d91111 Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2018-10-27 19:17:52 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2018-10-27 19:21:54 +0000 sys-devel/gcc: cut 1.11 patchset for 5.4.0 Eight new patches: + 99_all_remove-lieee.patch: drop assumed -lieee from -mieee-fp + 100_all_libgfortran-Werror.patch: + 101_all_libgomp-Werror.patch + 102_all_libitm-Werror.patch + 103_all_libatomic-Werror.patch + 104_all_libbacktrace-Werror.patch + 105_all_libsanitizer-libbacktrace-Werror.patch: pull in all -Werror patches from 8.2.0 + 106_all_libstdcxx-no-vtv.patch: drop libvtv RPATH from libstdc++ Bug: https://bugs.gentoo.org/667104 Bug: https://bugs.gentoo.org/475350 Bug: https://bugs.gentoo.org/229059 Bug: http://gcc.gnu.org/PR38436 Bug: https://bugs.gentoo.org/433435 Bug: http://gcc.gnu.org/PR54724 Bug: https://bugs.gentoo.org/582524 Bug: https://gcc.gnu.org/PR85884 Closes: https://bugs.gentoo.org/621178 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11 sys-devel/gcc/Manifest | 1 + sys-devel/gcc/gcc-5.4.0-r6.ebuild | 44 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+) |