Bug 228337 – improved ebuild for media-gfx/gimp

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Rémi Cardona (RETIRED) 2008-06-19 12:36:16 UTC]

Hi Hanno,

I installed gimp a couple days ago and I noticed that the Gnome menu entry didn't have any icon displayed. Digging a little deeper, I realized that the .desktop entry was 100% valid, that icon was good too, but just that the gimp ebuild did not run gtk-update-icon-cache at the end.

Opening up the ebuild, I just found out that gimp just didn't use the gnome2 eclass. So here's a patch for the 2.4.6 ebuild that "should" (I feel confident about the patch but I may have overlooked something) do _exactly_ what the old ebuild did, but using the gnome2 eclass, thus running the gtk-update-icon-cache at the end.

[Comment 1 Rémi Cardona (RETIRED) 2008-06-19 12:38:30 UTC]

Created attachment 157607 [details, diff]
patch to improve media-gfx/gimp-2.4.6

[Comment 2 Rémi Cardona (RETIRED) 2008-06-19 12:40:16 UTC]

Oh and btw, ./configure complains about non supported options, but it did even before I made my changes. There might be some more stuff to clean up in that area.

[Comment 3 Rémi Cardona (RETIRED) 2008-06-19 12:55:24 UTC]

Created attachment 157613 [details, diff]
patch to improve media-gfx/gimp-2.4.6 (take 2)

An even better patch that removes the handling of USE=doc and debug as they are both taken care of by the eclass.

And for the record, here's what configure says about the wrong options :

configure: WARNING: Unrecognized options: --without-curl, --with-hal, --without-wmf

[Comment 4 Hanno Böck 2008-06-21 18:50:59 UTC]

I've applied that. For the unrecognized options, curl was fixable, while for hal and wmf, they seem to be autodetected (bad behaviour).