Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 228219

Summary: x11-misc/fireflies-2.07 fails to build
Product: Gentoo Linux Reporter: Evil Compile Person <bugs>
Component: New packagesAssignee: Desktop Misc. Team <desktop-misc>
Status: RESOLVED FIXED    
Severity: normal CC: andrija.prcic, esigra, fauli, gassaf, tECHIDNA
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 198121    
Attachments: Modified fireflies ebuild
Patch to eliminate the gunzip | tar command at make
Patch to make gcc-4.3 happy with raster.cxx in libgfx

Description Evil Compile Person 2008-06-18 22:23:28 UTC
g++ -c -O2 -pipe -Wall -I../libgfx/include/ -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -I/var/tmp/portage/x11-misc/fireflies-2.07/work/fireflies-2.07/libgfx/include -DHAVE_CONFIG_H  geom3d.cxx
g++ -c -O2 -pipe -Wall -I../libgfx/include/ -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -I/var/tmp/portage/x11-misc/fireflies-2.07/work/fireflies-2.07/libgfx/include -DHAVE_CONFIG_H  raster.cxx
raster.cxx: In copy constructor 'ByteRaster::ByteRaster(const ByteRaster&)':
raster.cxx:18: error: 'memcpy' was not declared in this scope
raster.cxx: In copy constructor 'FloatRaster::FloatRaster(const FloatRaster&)':
raster.cxx:38: error: 'memcpy' was not declared in this scope
raster.cxx: At global scope:
raster.cxx:48: warning: deprecated conversion from string constant to 'char*'
raster.cxx:48: warning: deprecated conversion from string constant to 'char*'
raster.cxx:48: warning: deprecated conversion from string constant to 'char*'
raster.cxx:48: warning: deprecated conversion from string constant to 'char*'
raster.cxx:49: warning: deprecated conversion from string constant to 'char*'
raster.cxx:49: warning: deprecated conversion from string constant to 'char*'
raster.cxx:49: warning: deprecated conversion from string constant to 'char*'
raster.cxx:49: warning: deprecated conversion from string constant to 'char*'
raster.cxx: In function 'int infer_image_type(const char*)':
raster.cxx:60: error: 'strrchr' was not declared in this scope
raster.cxx:65: warning: comparison between signed and unsigned integer expressions
make[1]: *** [raster.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/x11-misc/fireflies-2.07/work/fireflies-2.07/libgfx/src'
make: *** [libgfx/src/libgfx.a] Error 2
 *
 * ERROR: x11-misc/fireflies-2.07 failed.

Portage 2.1.4.4 (default-linux/amd64/2007.0, gcc-4.3.1, glibc-2.8_p20080602-r0, 2.6.25.1 x86_64)
=================================================================
System uname: 2.6.25.1 x86_64 Dual-Core AMD Opteron(tm) Processor 2212 HE
Timestamp of tree: Tue, 17 Jun 2008 20:45:01 +0000
app-shells/bash:     3.2_p39
dev-lang/python:     2.5.2-r4
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.2.5
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.62
sys-devel/automake:  1.10.1-r1
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.4
virtual/os-headers:  2.6.25-r4
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="buildpkg distlocks metadata-transfer sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://216.165.129.134/gentoo http://gentoo.mirrors.tds.net/gentoo http://gentoo.osuosl.org/"
LANG="en_US"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://208.71.112.51/gentoo-portage"
USE="X acl amd64 berkdb cli cracklib crypt cups dri fortran gcj gdbm gpm iconv ipv6 isdnlog midi mmx mudflap ncurses nls nptl nptlonly objc openmp pam pcre perl pppd python readline reflection session spl sse sse2 ssl tcpd unicode xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="vga"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS, LINGUAS, MAKEOPTS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
Comment 1 Jabari R. Roberts 2008-07-29 23:28:54 UTC
This is a GCC 4.3 bug actually affecting an external compile-time library that comes with the Fireflies sources, called libgfx.

Patches and modified ebuild to follow.

Also, this bug needs to block bug 198121.
Comment 2 Jabari R. Roberts 2008-07-29 23:32:41 UTC
Created attachment 161676 [details]
Modified fireflies ebuild

The sources actually have a tgz'ed source of their own for libgfx, and it by default gets unpacked by fireflies' Makefile at the beginning of make.
I've eliminated that in another patch and had the source extracted during src_unpack().

I know it's not good to have an explicit tar command in the ebuild itself, but this is one of the first ebuilds I'm modifying.
Suggestions on making that part of the ebuild cleaner are welcome.
Comment 3 Jabari R. Roberts 2008-07-29 23:33:25 UTC
Created attachment 161677 [details, diff]
Patch to eliminate the gunzip | tar command at make
Comment 4 Jabari R. Roberts 2008-07-29 23:34:13 UTC
Created attachment 161679 [details, diff]
Patch to make gcc-4.3 happy with raster.cxx in libgfx
Comment 5 Gilbert Assaf 2008-09-12 22:27:06 UTC
Works like a charm.
Thank You!
Comment 6 Christian Faulhammer (RETIRED) gentoo-dev 2008-11-01 18:51:14 UTC
(In reply to comment #5)
> Works like a charm.
> Thank You!

 desktop-misc team, what is holding this bug up?

Comment 7 Peter Alfredsen (RETIRED) gentoo-dev 2008-12-17 22:31:19 UTC
+  17 Dec 2008; Peter Alfredsen <loki_val@gentoo.org>
+  +files/fireflies-2.07-gcc43.patch, fireflies-2.07.ebuild:
+  Fix bug 228219. Thanks to Jabari R. Roberts for the patch.
+