Bug 228137

Summary:	app-admin/webalizer-2.01.10-r16: geolizer-patch is non-functional
Product:	Gentoo Linux	Reporter:	Sven <sven.koehler>
Component:	New packages	Assignee:	Gentoo Web Application Packages Maintainers <web-apps>
Status:	RESOLVED FIXED
Severity:	normal	CC:	stolz
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	fixes use of AC_ARG_ENABLE fixes use of AC_ARG_ENABLE

Description Sven 2008-06-18 19:06:20 UTC

Hi,

so i just realized, that the webalizer ebuild is broken. Even though the geoip-useflag is turned on and the geolizer.patch is applied by the ebuild, the configure-run doesn't check for geoip-headers and libraries. And during compiling, i observe that the "-DUSE_GEOIP" is missing. As well as the "-lgeoip" in the linker command.

Please fix.


Reproducible: Always

Steps to Reproduce:

Comment 1 Sven 2008-06-18 19:11:46 UTC

LOL, also found the cause:

Don't pass "--enable-geoip" to configure, and it works.
Having "--enable-geoip" in the command line _disables_ GeoIP-support as if you had passed "--disable-geoip".

This must be a bug in the patch.

Comment 2 Sven 2008-06-27 20:41:29 UTC

Created attachment 158691 [details, diff]
fixes use of AC_ARG_ENABLE

So i've managed to make "--enable-geoip" and "--disable-geoip" work again as they should. Attached is the patch. Apply it AFTER geolizer patch.

Somebody just needs to add a proper epatch line to the ebuild. The eautoreconf is already there.

Comment 3 Sven 2008-06-27 20:47:08 UTC

Created attachment 158693 [details, diff]
fixes use of AC_ARG_ENABLE

new patch, since the old one didn't fix --disable-dns which was in fact enable dns code.

Comment 4 Gunnar Wrobel (RETIRED) gentoo-dev

2008-08-01 20:40:03 UTC

Reassigning to primary maintainer.

Comment 5 Sebastian Pipping gentoo-dev

2010-01-03 22:29:33 UTC

This should be fixed for webalizer-2.01.10-r17 now.  Please give it a try.  Thanks for reporting!