Bug 226849

Summary:	x11-misc/read-edid: patch (read-edid-arch.patch) changes both autotools source and result
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Desktop Misc. Team <desktop-misc>
Status:	RESOLVED INVALID
Severity:	normal	CC:	esigra
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	226305

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-06-14 17:46:43 UTC

The patch in summary is touching both Makefile.in and Makefile.am, probably to avoid autotools rebuild.

This treatment is usually reserved for a few selected system packages that cannot have their autotool scripts rebuilt.

This _could_ cause maintainermode-driven rebuild (see http://blog.flameeyes.eu/articles/2008/06/13/maintaner-mode ), which is something we should be avoiding as much as possible.

Please just patch Makefile.am and/or configure.in/.ac and rebuild autotools, unless you have very good reasons not to.

Comment 1 Krzysztof Pawlik (RETIRED) gentoo-dev

2008-06-17 12:52:18 UTC

The mentioned patch touches two files:

 * read-edid-1.4.1/Makefile.am
 * read-edid-1.4.1/configure.in

So it behaves properly - what precisely triggered this bug report? Diego, if this is from simple `grep` then last line of hunk for Makefile.am could trigger this:

  27  maintainer-clean-local:
  28     $(RM) Makefile.in aclocal.m4 config.h.in stamp-h.in configure

Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev

2008-06-17 16:24:52 UTC

It's a grep plus me looking at the patches, but looking as so many patches by hand false positives were expected :/ sorry for the noise.