Bug 226845

Summary:	x11-misc/lavaps: patch (lavaps-2.7-this-makes-it-compile.patch) changes both autotools source and result
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Desktop Misc. Team <desktop-misc>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	226305

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-06-14 17:45:21 UTC

The patch in summary is touching both Makefile.in and Makefile.am, probably to avoid autotools rebuild.

This treatment is usually reserved for a few selected system packages that cannot have their autotool scripts rebuilt.

This _could_ cause maintainermode-driven rebuild (see http://blog.flameeyes.eu/articles/2008/06/13/maintaner-mode ), which is something we should be avoiding as much as possible.

Please just patch Makefile.am and/or configure.in/.ac and rebuild autotools, unless you have very good reasons not to.

Comment 1 Peter Alfredsen (RETIRED) gentoo-dev

2008-06-29 13:19:28 UTC

   29 Jun 2008; Peter Alfredsen <loki_val@gentoo.org>
+  files/lavaps-2.7-build-fixes.patch,
+  files/lavaps-2.7-this-makes-it-compile.patch, lavaps-2.7-r2.ebuild:
+  Build-only fixes to avoid makefile patching, acinclude patching, and
+  sundry other ways people have abused this package over the years. Fixes
+  bug #226845.
+