Bug 226843

Summary:	x11-misc/adesklets: patch (adesklets-0.6.1-fix-as-needed.patch) changes both autotools source and result
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Gentoo Dockapp Team <desktop-dock>
Status:	RESOLVED WONTFIX
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	226305

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-06-14 17:44:42 UTC

The patch in summary is touching both Makefile.in and Makefile.am, probably to avoid autotools rebuild.

This treatment is usually reserved for a few selected system packages that cannot have their autotool scripts rebuilt.

This _could_ cause maintainermode-driven rebuild (see http://blog.flameeyes.eu/articles/2008/06/13/maintaner-mode ), which is something we should be avoiding as much as possible.

Please just patch Makefile.am and/or configure.in/.ac and rebuild autotools, unless you have very good reasons not to.

Comment 1 Michele Noberasco (RETIRED) gentoo-dev

2008-07-28 09:20:56 UTC

This package cannot easily have its autotools rebuilt, since some of its directories are missing Makefile.am files. Since the patches only touch Makefile.{am,in} and never configure.ac, I feel that maintainer-mode badness is not worth fixing (after all ./configure will run only once), as that would involve writing the missing Makefile.am files...

Feel free to reopen if you think it necessary :-)