Bug 226835

Summary:	x11-libs/libgksu: patch (libgksu-2.0.0-fbsd.patch) changes both autotools source and result
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Daniel Gryniewicz (RETIRED) <dang>
Status:	RESOLVED INVALID
Severity:	normal	CC:	gnome
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	226305

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-06-14 17:39:43 UTC

The patch in summary is touching both Makefile.in and Makefile.am, probably to avoid autotools rebuild.

This treatment is usually reserved for a few selected system packages that cannot have their autotool scripts rebuilt.

This _could_ cause maintainermode-driven rebuild (see http://blog.flameeyes.eu/articles/2008/06/13/maintaner-mode ), which is something we should be avoiding as much as possible.

Please just patch Makefile.am and/or configure.in/.ac and rebuild autotools, unless you have very good reasons not to.

Comment 1 Rémi Cardona (RETIRED) gentoo-dev

2008-10-28 23:50:31 UTC

Patching order is correct (.am before .in) and does not cause maintainer-mode reconfigure.

Closing