|Summary:||x11-libs/gtk+: patch (gtk+-2.8.0-multilib.patch) changes both autotools source and result|
|Product:||Gentoo Linux||Reporter:||Diego Elio Pettenò (RETIRED) <flameeyes>|
|Component:||New packages||Assignee:||Gentoo Linux Gnome Desktop Team <gnome>|
|Package list:||Runtime testing required:||---|
|Bug Depends on:|
Description Diego Elio Pettenò (RETIRED) 2008-06-14 17:38:41 UTC
The patch in summary is touching both Makefile.in and Makefile.am, probably to avoid autotools rebuild. This treatment is usually reserved for a few selected system packages that cannot have their autotool scripts rebuilt. This _could_ cause maintainermode-driven rebuild (see http://blog.flameeyes.eu/articles/2008/06/13/maintaner-mode ), which is something we should be avoiding as much as possible. Please just patch Makefile.am and/or configure.in/.ac and rebuild autotools, unless you have very good reasons not to.
Comment 1 Mart Raudsepp 2008-06-21 22:26:10 UTC
I'm sorry, but there is no technical reason this could cause any problems, other than getting the emerge succeed too fast once we are able to remove the other patches that do make us call eautoreconf currently. Feel free to open with a technical reason for not patching Makefile.in's, and therefore forcing to use eautoreconf and a longer emerge time on users. Meanwhile, INVALID.