Bug 226703

Summary:	dev-lang/wml: patch (wml-2.0.11-autotools.patch) changes both autotools source and result
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Hans de Graaff <graaff>
Status:	RESOLVED WORKSFORME
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	226305

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-06-14 16:09:44 UTC

The patch in summary is touching both Makefile.in and Makefile.am, probably to avoid autotools rebuild.

This treatment is usually reserved for a few selected system packages that cannot have their autotool scripts rebuilt.

This _could_ cause maintainermode-driven rebuild (see http://blog.flameeyes.eu/articles/2008/06/13/maintaner-mode ), which is something we should be avoiding as much as possible.

Please just patch Makefile.am and/or configure.in/.ac and rebuild autotools, unless you have very good reasons not to.

Comment 1 Hans de Graaff gentoo-dev

2008-06-14 20:54:54 UTC

It is doing so because several different directories exist, some only with Makefile.in and some with Makefile.am. Guess you didn't think about that edge case. :-)

Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev

2008-06-14 22:06:10 UTC

Sincerely, I didn't expect it at all :) But I remember now looking at wml before, and it gave me enough creeps without knowing it deeply :P sorry for the noise