Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 226439

Summary: app-text/gv: autotools are being rebuilt through maintainer-mode
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Printing Team <printing>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 226305    
Attachments: build.log for app-text/gv-3.6.4

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-06-13 20:41:42 UTC
Rebuilding autotools through maintainer-mode is _not_ good, because it usually means you forget to add dependencies, and they'll magically use the same version as used by upstream, which might not be what the user have installed at all.

If you patch Makefile.am or configure.in/configure.ac you _have to_ use autotools.eclass and eautomake/eautoreconf. Exceptions are granted _only_ for system packages that would make it impossible to run autotools during stagebuilding.

Please fix your package.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2008-06-21 07:34:25 UTC
Created attachment 157863 [details]
build.log for app-text/gv-3.6.4

Diego, I've bumped app-text/gv to 3.6.4 and changed it to modify only Makefile.am instead of also Makefile.in, then inherited autotools and ran eautoreconf. Why am I still getting..

>>> Completed installing gv-3.6.4 into /var/tmp/portage/app-text/gv-3.6.4/image/

 * QA Notice: Automake "maintainer mode" detected:
 * 
 * 		if (/bin/sh /var/tmp/portage/app-text/gv-3.6.4/work/gv-3.6.4/missing --run makeinfo --version) >/dev/null 2>&1; then \
 * 		if /bin/sh /var/tmp/portage/app-text/gv-3.6.4/work/gv-3.6.4/missing --run makeinfo   -I . \
 * 
 * If you patch Makefile.am, configure.in,  or configure.ac then you
 * should use autotools.eclass and eautomake or eautoreconf. Exceptions
 * are limited to system packages for which it is impossible to run
 * autotools during stage building. See
 * http://www.gentoo.org/proj/en/qa/autofailure.xml for more information.
strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment

?
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2010-06-12 22:05:24 UTC
The problem disappeared with 3.7.1. Please reopen if you can still reproduce.