Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 226397

Summary: x11-themes/fvwm-themes: autotools are being rebuilt through maintainer-mode
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Desktop WM Team (OBSOLETE) <desktop-wm+disabled>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 226305    

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-06-13 19:46:20 UTC
Rebuilding autotools through maintainer-mode is _not_ good, because it usually means you forget to add dependencies, and they'll magically use the same version as used by upstream, which might not be what the user have installed at all.

If you patch Makefile.am or configure.in/configure.ac you _have to_ use autotools.eclass and eautomake/eautoreconf. Exceptions are granted _only_ for system packages that would make it impossible to run autotools during stagebuilding.

Please fix your package.
Comment 1 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-05-28 12:42:13 UTC
Fixed in tree:


+  28 May 2010; Kacper Kowalik <xarthisius@gentoo.org>
+  fvwm-themes-0.7.0.ebuild, files/fvwm-themes-0.7.0-posix-sort.patch:
+  Fixing autotools rebuilt through maintainer-mode wrt bug 226397, thanks to
+  Diego for report.
+  Fixing dependency on media-gfx/{image,graphics}magick wrt bug 314415,
+  thanks to
+  Wojciech Porczyk for report.
+  Simplifying configure phase, skipping useless einfo, don't copy INSTALL
+