Summary: | x11-libs/vte and x11-terms/gnome-terminal don't allow disabling of keystroke scroll for alternate screen | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Heath Caldwell (RETIRED) <hncaldwell> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED UPSTREAM | ||
Severity: | enhancement | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://bugzilla.gnome.org/show_bug.cgi?id=518405 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
vte patch to turn feature on or off
gnome-terminal patch to configure the feature Unified diff for vte patch Unified diff for gnome-terminal patch |
Description
Heath Caldwell (RETIRED)
2008-06-13 19:35:33 UTC
Created attachment 156653 [details, diff]
vte patch to turn feature on or off
Here is a patch to add the ability to toggle alternate screen keystroke
scrolling.
Created attachment 156655 [details, diff]
gnome-terminal patch to configure the feature
Here is a patch for gnome-terminal that allows the user to configure turning
the feature on or off.
(In reply to comment #0) > I will attach patches that make the feature configurable. Please attach 'unified' diffs (diff -urNp should be good enough) when submitting patches. These are the de-facto standard, more compact, and much easier to review. Created attachment 156669 [details, diff]
Unified diff for vte patch
Created attachment 156671 [details, diff]
Unified diff for gnome-terminal patch
(In reply to comment #3) > Please attach 'unified' diffs (diff -urNp should be good enough) Done. I'm watching the upstream discussion. Not sure if I should apply this or not (even though the scrolling in screen really annoying). I'd obviously prefer a solution that actually worked for screen, but that may not be a possibility. (In reply to comment #7) This seems to me to be the only valid solution. Anything else would be a work around to avoid or mollify the keystroke feature. It seems perfectly reasonable to simply make it configurable and let the user decide whether or not they want it. Unfortunately, I seem to be having trouble convincing the vte maintainer that this is what is best for the users. Does the rest of gnome team think we should include this downstream or wait for upstream? In the last case, I would vote for closing this as "UPSTREAM" As I can read in last comments from upstream bug report, this patch won't be included as-is and needs more work, then, this needs to be handled directly with upstream in upstream bug report: http://bugzilla.gnome.org/show_bug.cgi?id=518405 |