Bug 226061

Summary:	app-office/openoffice: Suggests moving ooffice.sh to /usr/share/bash-completion
Product:	Gentoo Linux	Reporter:	Richard Li <admin>
Component:	Current packages	Assignee:	Gentoo Office Team <office>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	coldwind, darkside, marsoft
Priority:	High	Keywords:	Inclusion
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	makes bash-completion option and places it in the correct location

Description Richard Li 2008-06-12 13:15:27 UTC

Currently ooffice.sh is placed in /etc/bash_completion.d, so it is always sourced if the user enables extended bash completion by sourcing /etc/profile.d/bash-completion

I'd suggest moving the file to /usr/share/bash-completion, then users will be able to use command "eselect bashcomp" to control if they want it.

Reproducible: Always

Steps to Reproduce:
1. Emerge =app-office/openoffice-2.4.1 (probably also in earlier versions)
2.
3.

Comment 1 Andreas Proschofsky (RETIRED) gentoo-dev

2008-06-12 21:21:25 UTC

I agree ;) Just didn't come around to fixing this, so feel free to provide a patch to speed it up...

Comment 2 Simeon Maryasin 2008-12-13 15:41:51 UTC

Maybe also make this file executable? Because all files in /usr/share/bash-completion are executable...

Comment 3 Santiago M. Mola (RETIRED) gentoo-dev

2008-12-19 10:54:16 UTC

Andreas, this change could Also, please, call it 'ooffice'. You can use dobashcompletion from bash-completion.eclass to install the file.

Comment 4 Santiago M. Mola (RETIRED) gentoo-dev

2008-12-19 10:54:51 UTC

heh, misredaction, s/this change could Also,//

Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester

2009-02-27 13:56:11 UTC

Created attachment 183368 [details, diff]
makes bash-completion option and places it in the correct location

(In reply to comment #1)
> I agree ;) Just didn't come around to fixing this, so feel free to provide a
> patch to speed it up...
> 

Here you go.

Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester

2009-02-27 23:50:52 UTC

(In reply to comment #5)
> Created an attachment (id=183368) [edit]
> makes bash-completion option and places it in the correct location
> 

Oh, dang. It should be:

+       BASH_COMPLETION_NAME=ooffice
+       bash-completion_pkg_postinst

for that part.

Comment 7 Jeremy Olexa (darkside) (RETIRED) archtester

2009-04-09 05:01:23 UTC

Be nice to get something like this in the future 3.1 or 3.0.1 stuff =)

Comment 8 Andreas Proschofsky (RETIRED) gentoo-dev

2009-05-19 11:34:26 UTC

This is done in OOo 3.1.0, thanks for the patch! Closing.