| Summary: | file: pym/protage/__init__.py function: abssymlink | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | zy <goodmenzy> |
| Component: | Core | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | InVCS |
| Priority: | High | ||
| Version: | 2.2 | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 459934 | ||
no reply ? maybe this info is posted in the wrong place.................. It's in the right place. The thing is, that function is only used in one place and it's in the merge code which happens to be extremely critical. Please just give us some time to review your patch. I'd prefer not to change the behavior, so instead I've updated the docs: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=d6dd49ff7fd6308127474064bccec03b3442f9b5 This is fixed in 2.1.11.53 and 2.2.0_alpha164. |
in file pym/portage/__init__py, line 184, the function abssymlink seem not confront it's description the return value is not a absolute path when the symlink param is in corrent dir I think it should use os.path.abspath() to get the result Here is my suggestion version: # ==================================================================== def abssymlink(symlink): "This reads symlinks, resolving the relative symlinks, and returning the absolute." mylink=os.readlink(symlink) if mylink[0] != '/': # mydir=os.path.dirname(symlink) mydir = "." mylink=mydir+"/"+mylink # return os.path.normpath(mylink) return os.path.abspath(mylink) # ==================================================================== any comment ?