Summary: | net-dialup/freeradius-2.0.4 fails with --as-needed and contains a bundled libltdl | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Tiziano Müller (RETIRED) <dev-zero> |
Component: | New packages | Assignee: | Alin Năstac (RETIRED) <mrness> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mail, mathieu.segaud, net-dialup |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Ebuild fixing 225725 and 225937
Fix to define _GNU_SOURCE in C sources. New ebuild fixing both bugs. |
Description
Tiziano Müller (RETIRED)
2008-06-10 10:13:36 UTC
This is not related to --as-needed, it happens anyhow you setup your ldflags. Seems related to libtool-2.2.4 (build fails since upgrade to libtool-2.2.4) hmm, interesting. Well, unbundling libltdl will then probably solve the issue. (In reply to comment #2) > hmm, interesting. Well, unbundling libltdl will then probably solve the issue. > Done. configure script's got a --with-system-libtool option, unset by default. I attach an ebuild fixing this bug and bug #225937 (by append-flags'ing -D_GNU_SOURCE) Created attachment 156607 [details]
Ebuild fixing 225725 and 225937
Right solution for the libtool-dep. Wrong solution for the _GNU_SOURCE: Upstream must fix it, so a patch is more likely the way to go. (In reply to comment #5) > Right solution for the libtool-dep. Wrong solution for the _GNU_SOURCE: > Upstream must fix it, so a patch is more likely the way to go. yep, I too guess so. But I only followed what was done for some other bugs added to #225459 :). Will upload a patch soon. Thanks. (In reply to comment #6) > (In reply to comment #5) > > Right solution for the libtool-dep. Wrong solution for the _GNU_SOURCE: > > Upstream must fix it, so a patch is more likely the way to go. > > yep, I too guess so. But I only followed what was done for some other bugs > added to #225459 :). > Will upload a patch soon. Thanks. > New ebuild with freeradius-2.0.4-define-gnu-source.patch. I added a call to eautoheader to have src/include/autoconf.h.in regenerated. Created attachment 156613 [details, diff]
Fix to define _GNU_SOURCE in C sources.
Created attachment 156615 [details]
New ebuild fixing both bugs.
Fixed in -r1. Thanks for the solution! However, I had to make some changes: - the patch should be applied only if elibc_glibc USE flag is enabled - the right way to define it is AC_DEFINE(_GNU_SOURCE, 1, [some comment]) |