Bug 225425 – sys-apps/net-tools-1.60_p20071202044231-r1 build error in ec_hw.c: NULL undefined

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jose daLuz 2008-06-08 19:03:54 UTC]

Rebuilding net-tools 1.60_p20071202044231-r1 (as part of system rebuild) after updating glibc from 2.7-r2 to 2.8_p20080602, I get the following error:

neric EUI-64 hardware support (HAVE_HWEUI64) [y] InfiniBand hardware support (HAVE_HWIB) [y] *
*
*           Other Features.
*
IP Masquerading support (HAVE_FW_MASQUERADE) [y] Build iptunnel and ipmaddr (HAVE_IP_TOOLS) [y] Build mii-tool (HAVE_MII) [y] make -j4 libdir
make[1]: Entering directory `/var/tmp/paludis/sys-apps-net-tools-1.60_p20071202044231-r1/work/net-tools-1.60_p20071202044231/lib'
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o activate.o activate.c
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o af.o af.c
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o arcnet.o arcnet.c
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o ash.o ash.c
ash.c: In function 'in_ash':
ash.c:67: warning: pointer targets in assignment differ in signedness
ash.c: In function 'pr_sash':
ash.c:112: warning: pointer targets in passing argument 1 of 'pr_ash' differ in signedness
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o ax25.o ax25.c
arcnet.c: In function 'in_arcnet':
arcnet.c:55: warning: pointer targets in assignment differ in signedness
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o ax25_gr.o ax25_gr.c
ax25.c: In function 'AX25_sprint':
ax25.c:76: warning: pointer targets in passing argument 1 of 'AX25_print' differ in signedness
ax25.c: In function 'AX25_input':
ax25.c:87: warning: pointer targets in assignment differ in signedness
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o ddp.o ddp.c
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o ddp_gr.o ddp_gr.c
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o ec_hw.o ec_hw.c
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o econet.o econet.c
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o ether.o ether.c
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o eui64.o eui64.c
ddp.c: In function 'ddp_sprint':
ddp.c:51: warning: pointer targets in passing argument 1 of 'ddp_print' differ in signedness
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o fddi.o fddi.c
ether.c: In function 'in_ether':
ether.c:59: warning: pointer targets in assignment differ in signedness
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o frame.o frame.c
eui64.c: In function 'in_eui64':
eui64.c:72: warning: pointer targets in assignment differ in signedness
x86_64-pc-linux-gnu-gcc -march=k8 -O2 -pipe -ggdb -msse3 -Wall -I.. -idirafter ../include  -D_GNU_SOURCE -I. -idirafter ./include/ -Ilib  -c -o getargs.o getargs.c
ec_hw.c:24: error: 'NULL' undeclared here (not in a function)
make[1]: *** [ec_hw.o] Error 1
make[1]: *** Waiting for unfinished jobs....
fddi.c: In function 'in_fddi':
fddi.c:69: warning: pointer targets in assignment differ in signedness
make[1]: Leaving directory `/var/tmp/paludis/sys-apps-net-tools-1.60_p20071202044231-r1/work/net-tools-1.60_p20071202044231/lib'
make: *** [libdir] Error 2

!!! ERROR in sys-apps/net-tools-1.60_p20071202044231-r1:
Portage 2.1.5.4 (default-linux/amd64/2007.0/desktop, gcc-4.3.0, glibc-2.8_p20080602-r0, 2.6.25-gentoo-r4 x86_64)
=================================================================
System uname: 2.6.25-gentoo-r4 x86_64 AMD Athlon(tm) 64 X2 Dual Core Processor 6000+
Timestamp of tree: Sun, 08 Jun 2008 01:35:01 +0000
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.5.2-r4
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.2.5
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.62
sys-devel/automake:  1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.4
virtual/os-headers:  2.6.25-r3
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=k8 -O2 -pipe -ggdb -msse3"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-march=k8 -O2 -pipe -ggdb -msse3"
DISTDIR="/usr/portage/distfiles"
FEATURES="ccache distlocks fixpackages parallel-fetch sandbox sfperms splitdebug strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://gentoo.osuosl.org/ http://distro.ibiblio.org/pub/linux/distributions/gentoo/"
LANG="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
LDFLAGS=""
LINGUAS="en"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/overlays/paludis-extras /usr/local/overlays/sunrise /usr/local/overlays/gnome /usr/local/overlays/mainline /usr/local/overlays/desktop-effects /usr/local/overlays/vmware /usr/local/overlays/berkano /usr/local/overlays/myoverlay"
SYNC="rsync://rsync.us.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 amr bash-completion berkdb bluetooth bzip2 cairo cdda cdr cli cracklib crypt css cups dbus dri dts dvd dvdr dvdread eds emboss encode esd evo fam ffmpeg flac fortran gdbm gif glitz gnome gpm gstreamer gtk hal iconv ipv6 isdnlog java jpeg kde kdehiddenvisibility kerberos ldap libnotify mad midi mikmod mmx mono mp3 mpeg mudflap ncurses nls nptl nptlonly ogg opengl openmp pam pcre pdf perl pic png pppd python qt3support qt4 quicktime readline reflection ruby samba sdl session spell spl sqlite sse sse2 ssl svg tcpd theora tiff truetype unicode usb userlocales vcd vorbis x264 xml xorg xulrunner xv xvid zlib" ALSA_CARDS="cmipci hdaintel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Mario Fetka (geos_one) 2008-06-09 03:30:02 UTC]

Created attachment 156029 [details, diff]
ec_hw.c NULL patch

!!! this bug isn't a glibc bug its a gcc 4.3 bug !!!

only place the file into net-tools/files/1.60_p20071202044231/ and redigest.

[Comment 2 Jose daLuz 2008-06-09 03:47:32 UTC]

(In reply to comment #1)
> Created an attachment (id=156029) [edit]
> ec_hw.c NULL patch
> 
> !!! this bug isn't a glibc bug its a gcc 4.3 bug !!!
> 
> only place the file into net-tools/files/1.60_p20071202044231/ and redigest.
> 
That works, thanks. Changing summary and block to reflect gcc 4.3.

[Comment 3 teidakankan 2008-06-09 04:09:29 UTC]

(In reply to comment #1)
> Created an attachment (id=156029) [edit]
> ec_hw.c NULL patch
> 
> !!! this bug isn't a glibc bug its a gcc 4.3 bug !!!
> 
> only place the file into net-tools/files/1.60_p20071202044231/ and redigest.
> 

Just a side note.  I had this problem with gcc 4.2.4 and glibc-2.8_p20080602.  I've since backed down to glibc-2.7-r2 so I can't test this now but will later.

[Comment 4 SpanKY 2008-06-09 05:18:20 UTC]

Comment on attachment 156029 [details, diff]
ec_hw.c NULL patch

this is obviously incorrect

[Comment 5 SpanKY 2008-06-09 05:26:54 UTC]

fixed in cvs

[Comment 6 walt 2009-08-24 16:38:42 UTC]

This same fix now needs to be applied to net-tools-1.60-r13

[Comment 7 SpanKY 2009-08-24 21:05:20 UTC]

no it doesnt