Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 224917

Summary: ESVN_BOOTSTRAP and EGIT_BOOTSTRAP seem to suggest using bootstrap/autogen scripts, should launch a QA warning
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: [OLD] DevelopmentAssignee: Gentoo Quality Assurance Team <qa>
Status: CONFIRMED ---    
Severity: normal CC: ciaran.mccreesh, ferdy
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 226305    

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-06-04 17:50:45 UTC
The ESVN_BOOTSTRAP and EGIT_BOOTSTRAP variables seems to be used only to call boostrap/autogen scripts (instead of using eautoreconf).

Considering that boostrap/autogen scripts are usually a very nasty idea, I'd like for use of the two variable to raise a QA Warning.

If further steps are needed after the source fetching through subversion/git, it should happen in src_unpack as we do for every other thing in other ebuilds and eclasses.

(Similarly, ESVN_PATCHES and EGIT_PATCHES should be deprecated too, if we really want to make that change, we could just let subversion and git eclasses inherit base.eclass and use the already-present PATCHES array, instead of reinventing the wheel).
Comment 1 Ciaran McCreesh 2008-06-04 18:04:46 UTC
You're assuming that bootstrap scripts can be replaced by calling eautoreconf. This often isn't the case.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-06-04 18:08:43 UTC
No I'm not.

> If further steps are needed after the source fetching through subversion/git,
> it should happen in src_unpack as we do for every other thing in other ebuilds
> and eclasses.
Comment 3 Ciaran McCreesh 2008-06-04 18:10:15 UTC
Sure. And that thing is often "run the autogen / bootstrap" script. So you might as well just use the *_BOOTSTRAP var.
Comment 4 Mark Loeser (RETIRED) gentoo-dev 2010-10-19 20:29:50 UTC
Any input from anyone on how they would like to proceed with this bug?  Its been stalled for quite some time now.