Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 223281

Summary: x11-drivers/ati-drivers 8.493 (ATI Catalyst 8.5) version bump
Product: Gentoo Linux Reporter: Matteo Modesti <mattemod>
Component: New packagesAssignee: Jeffrey Gardner (RETIRED) <je_fro>
Status: RESOLVED FIXED    
Severity: enhancement CC: crazy-ivanovic, daniel, ehrenkranz, fauli, gentoo, jan.bednar, kroemmelbein, luca.genasci, lu_zero, manschwetus, thoward1120
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://ati.amd.com/support/drivers/linux64/linux64-radeon.html
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: ebuild for 8.493

Description Matteo Modesti 2008-05-23 00:13:04 UTC
On May 21 ATI Catalyst 8.5 has been released.
It brings new features and lots of bugfixes, so it'd be great to have it in the tree ASAP...

Reproducible: Always

Steps to Reproduce:
Comment 1 Nils Kneuper 2008-05-23 09:28:22 UTC
Since it is probably needed to adjust the ebuild:

"(...)In preparation of other work to come, Catalyst 8.5 for Linux adds a libatiadlxx.so file.(...)"
http://www.phoronix.com/scan.php?page=article&item=catalyst_85_linux&num=1

So the ebuild has to be adjusted, plain copy&paste might result in strange problems. Though I have not tested it so far, but in the long run it is likely...
Comment 2 Nils Kneuper 2008-05-23 09:33:43 UTC
Oh, and to prevent some problems with kernel 2.6.25.x users, it might be a good idea to add a check/message to warn that the unused symbols have to be exported in the kernel, otherwise it will result in a message along the lines of "fglrx: Unknown symbol __init_mm"

Symbol: UNUSED_SYMBOLS [=y]                                                                                     
Prompt: Enable unused/obsolete exported symbols                                                                 
  Defined at lib/Kconfig.debug:42                                                                               
  Location:                                                                                                     
    -> Kernel hacking

With this option everything should work fine. A different solution that was proposed in the phoronix forums was to edit the license part of the driver itself by hand, so that it identified itself as GPL and could be used, though I think this is a really bad solution to do for the distribution package...
Comment 3 Thomas S. Howard 2008-05-23 19:04:19 UTC
(In reply to comment #1)
> Since it is probably needed to adjust the ebuild:
> 
> "(...)In preparation of other work to come, Catalyst 8.5 for Linux adds a
> libatiadlxx.so file.(...)"
> http://www.phoronix.com/scan.php?page=article&item=catalyst_85_linux&num=1
> 
> So the ebuild has to be adjusted, plain copy&paste might result in strange
> problems. Though I have not tested it so far, but in the long run it is
> likely...
> 

Nope.  Installs the file just fine.  Also, as I type, I'm running on the driver just fine as well.  The symbol problem comes down to two in the file /usr/src/linux/kernel/rcupreempt.c, both marked as this:

EXPORT_SYMBOL_GPL(__rcu_read_lock);
EXPORT_SYMBOL_GPL(__rcu_read_unlock);

Also, I didn't enable exporting of unused/obsolete symbols, and the module inserted just fine (and worked fine too). However, enabling said option does not correct the problem with GPL symbols.  Either you modify the driver's license, or you unconditionally export those two symbols, which I what I did.  Not sure what the proper solution for Gentoo is. This is with sys-kernel/gentoo-sources-2.6.25-r4.
Comment 4 Thomas S. Howard 2008-05-23 19:10:27 UTC
Created attachment 154089 [details]
ebuild for 8.493

Oh, yeah, the ebuild also requires this to be removed:

   if kernel_is ge 2 6 25; then
                die "${P} is not compatible with kernel 2.6.25 and greater"
   fi

I'm attaching my local version.
Comment 5 Thomas S. Howard 2008-05-23 19:46:09 UTC
Forgot to add, another solution is to not enable this kernel option:

Processor type and features  ---> 
	[ ] Preemptible RCU 


which avoids using the symbols entirely.


Comment 6 Luca Barbato gentoo-dev 2008-05-24 15:19:10 UTC
In portage, thank you all