Bug 22230 – gtksubtitler-0.2.4.ebuild (New Package)

• Product: Gentoo Linux
• Status: RESOLVED INVALID

[Description Adam Mondl (RETIRED) 2003-06-04 14:40:57 UTC]

GTKsubtitler is a tool for editing and converting subtitles for DivX films. It
allows you to move subtitles, change their format, convert them to ISO-8859-1/2,
and merge two sets of subtitles.

This package only depends on GTK, but as a result of a current bug Gnome is
required as a dependency as well.  Trying to disable gnome during configuration
just results in a lot of internal errors.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Adam Mondl (RETIRED) 2003-06-04 14:45:03 UTC]

Created attachment 12798 [details]
gtksubtitler-0.2.4.ebuild (New Package)

[Comment 2 Adam Mondl (RETIRED) 2003-06-04 14:46:36 UTC]

Created attachment 12799 [details]
ChangeLog

[Comment 3 Adam Mondl (RETIRED) 2003-06-06 10:36:22 UTC]

Comment on attachment 12799 [details]
ChangeLog

># ChangeLog for media-video/gtksubtitler
># Copyright 2002-2003 Gentoo Technologies, Inc.; Distributed under the GPL v2
># $Header: $
>
>*gtksubtitler-0.2.4 (3 June 2003)
>
>  3 June 2003; Adam Mondl <[e-mail]> gtksubtitler-0.2.4.ebuild:
>  Initial release.

[Comment 4 foser (RETIRED) 2003-06-10 08:47:58 UTC]

a few points that need improving

1) never depend on the gnome-meta package, find the right deps in configure.in or similar . Can you maybe patch out it's gnome dep if it only needs gtk+, that would  be much nicer.
2) SRC_URI would be easier with ${P} or ${PV} at least
3) You should set the package name to lowercase using a ${MY_P} var or something and use it troughout the ebuild. Setting ${S} correctly with that for example you don't need to use both cd statements .
4) again with the correct use ${MY_P} the src_unpack part can be removed.

[Comment 5 Adam Mondl (RETIRED) 2003-06-10 21:33:30 UTC]

Created attachment 13085 [details]
Modified ebuild with proposed changes.

I took care of the Gnome dependency as well as incorporated ${P} and ${PV}.  I
added a non-functional MY_P variable but I am still not sure how to take care
of the v in the filename.  Please explain further how I could solve this
problem.

[Comment 6 Mike Gardiner (RETIRED) 2003-09-04 03:35:09 UTC]

i know this is an application written in gtk and using the gnome libraries, but the application itself fits more in a video/media category ? thoughts ?

[Comment 7 foser (RETIRED) 2003-09-04 04:18:12 UTC]

i suppose app-editor needs to be considered. Depends on wheter video/tv herd is willing to take it.

The ebuilds itsself : 

the gtk dep is 1.2 only i suppose so should be '=x11-libs/gtk+-1.2*'

i don't like the usage of gawk there, although it's baselayout it isn't really needed (in essence it adds another dep). easiest is to just define ${MY_P}=<text>-${PV} and use that troughout.

[Comment 8 Adam Mondl (RETIRED) 2003-09-04 05:05:19 UTC]

Created attachment 17054 [details]
Modified Ebuild with newer changes

I added an einfo giving the location of the binary since it is not all
lowercase.  Also I tried to fix the two things foser mentioned.

[Comment 9 Adam Mondl (RETIRED) 2003-09-06 14:20:24 UTC]

Created attachment 17187 [details]
Modified Ebuild with newer changes

DEPEND="=x11-libs/gtk+-1.2*"  typo

[Comment 10 Adam Mondl (RETIRED) 2004-02-29 10:22:09 UTC]

I guess under GLEP policy #17 this bug should be closed as a won't fix.

[Comment 11 Adam Mondl (RETIRED) 2004-12-06 16:01:46 UTC]

Project has been closed.