Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 221745

Summary: qmake from qt 4.4.0_rc1 generates Makefile's that prestrip files
Product: Gentoo Linux Reporter: Alexis Ballier <aballier>
Component: EclassesAssignee: Qt Bug Alias <qt>
Status: RESOLVED FIXED    
Severity: normal CC: flameeyes, hrz, pacho, pesa
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 255918, 255920    
Attachments: Patch for /usr/portage/eclass/qt4.eclass
qt4.eclass.diff

Description Alexis Ballier gentoo-dev 2008-05-11 19:30:04 UTC
I noticed that with texmaker when I had prestripped files:

$ cat foo.pro 
TEMPLATE        = app
LANGUAGE        = C++
TARGET   = foo
SOURCES += main.cpp
DEFINES += PREFIX=\\\"$${PREFIX}\\\"
target.path = $${PREFIX}/bin
INSTALLS = target

$ qmake foo.pro
$ grep strip Makefile 
	-strip "$(INSTALL_ROOT)/bin/$(QMAKE_TARGET)"

Imho eqmake4 should take care of this if that's the way qmake is meant to be.
I dont remember seeing that with older qt versions though.
Comment 1 Ingmar Vanhassel (RETIRED) gentoo-dev 2008-06-07 14:17:46 UTC
*** Bug 225203 has been marked as a duplicate of this bug. ***
Comment 2 Alexis Ballier gentoo-dev 2008-12-23 12:35:51 UTC
*** Bug 251870 has been marked as a duplicate of this bug. ***
Comment 3 Hanno Böck gentoo-dev 2008-12-23 14:42:40 UTC
*** Bug 252043 has been marked as a duplicate of this bug. ***
Comment 4 Homme Zwaagstra 2009-01-07 16:47:09 UTC
Created attachment 177687 [details, diff]
Patch for /usr/portage/eclass/qt4.eclass

This should fix the problem by replacing strip commands with harmless echo commands.

More information is available here:
http://doc.trolltech.com/4.2/qmake-running.html#makefile-mode-options
http://doc.trolltech.com/qtextended4.4/qbuild/qb-var-mkspec-strip-2.html
Comment 5 Pacho Ramos gentoo-dev 2009-01-09 10:18:59 UTC
Created attachment 177856 [details, diff]
qt4.eclass.diff

Seems that running "echo" is not required and this is enough
Comment 6 Davide Pesavento (RETIRED) gentoo-dev 2009-01-09 11:59:21 UTC
(In reply to comment #5)
> Created an attachment (id=177856) [edit]
> qt4.eclass.diff
> 
> Seems that running "echo" is not required and this is enough
> 

Yeah! This is also much better than running sed on the generated Makefile, as I proposed in bug #244692. It's not good to see once again that qmake is so badly documented.
Comment 7 Markos Chandras (RETIRED) gentoo-dev 2009-02-25 20:27:34 UTC
This bug can now close

I fixed the qt4.eclass 

Thanks for reporting