Bug 221059 – mail-client/kbiff-3.8 fails to compile on ASUS board enabled machines

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Oliver Maurhart 2008-05-09 09:20:00 UTC]

If someone has an ASUS board, kbiff implements the ability to support the LEDs to flash them on and off if mail arrives.

However the source code is poorly programmed and fails to compile if kbiff successfuly detected ASUS kernel support. On emerge it gives:

/bin/sh ../libtool --silent --mode=compile --tag=CXX i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/kde/3.5/include -I/usr/qt/3/include -I.  -I/usr/kde/3.5/include  -DQT_THREAD_SUPPORT  -D_REENTRANT  -Wnon-virtual-dtor -Wno-long-long -Wundef -Wall -pedantic -W -Wpointer-arith -Wwrite-strings -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -DNDEBUG -DNO_DEBUG -O2 -O2 -march=i686 -pipe -msse3 -fno-exceptions -fno-check-new  -c -o led.lo `test -f 'led.cpp' || echo './'`led.cpp
/usr/qt/3/bin/moc ./setupdlg.h -o setupdlg.moc.cpp
/usr/qt/3/bin/moc ./kbiffmonitor.h -o kbiffmonitor.moc.cpp
/usr/qt/3/bin/moc ./kbiff.h -o kbiff.moc.cpp
/usr/qt/3/bin/moc ./status.h -o status.moc.cpp
/usr/qt/3/bin/moc ./notify.h -o notify.moc.cpp
echo > dummy.cpp
/bin/sh ../libtool --silent --mode=compile --tag=CXX i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/kde/3.5/include -I/usr/qt/3/include -I.  -I/usr/kde/3.5/include  -DQT_THREAD_SUPPORT  -D_REENTRANT  -Wnon-virtual-dtor -Wno-long-long -Wundef -Wall -pedantic -W -Wpointer-arith -Wwrite-strings -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -DNDEBUG -DNO_DEBUG -O2 -O2 -march=i686 -pipe -msse3 -fno-exceptions -fno-check-new  -c -o setupdlg.moc.lo `test -f 'setupdlg.moc.cpp' || echo './'`setupdlg.moc.cpp
led.cpp: In constructor 'Led::Led(const char*)':
led.cpp:37: error: 'string' was not declared in this scope
led.cpp:37: error: expected `;' before 'fname'
led.cpp:39: error: expected type-specifier before 'ofstream'
led.cpp:39: error: cannot convert 'int*' to 'std::ofstream*' in assignment
led.cpp:39: error: expected `;' before 'ofstream'
led.cpp:45: error: 'cerr' was not declared in this scope
led.cpp: At global scope:
led.cpp:35: warning: unused parameter 'ledname'
make[3]: *** [led.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory `/var/tmp/portage/mail-client/kbiff-3.7.1/work/kbiff-3.7.1/kbiff'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/mail-client/kbiff-3.7.1/work/kbiff-3.7.1/kbiff'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/mail-client/kbiff-3.7.1/work/kbiff-3.7.1'
make: *** [all] Error 2


Reproducible: Always

Actual Results:  
It fails to compile.

Expected Results:  
Well ... it should compile fine.

Applying the attached patch for the kbiff-3.8 fixes the problem and adds ASUS board support to kbiff.

[Comment 1 Oliver Maurhart 2008-05-09 09:21:40 UTC]

Created attachment 152599 [details, diff]
fix compile on kbiff-3.8 ASUS board LEDs

[Comment 2 Jaime Martin 2008-12-29 17:56:06 UTC]

Hi, 

I have the same error in my ASUS laptop. Please, submit the ebuild with the patch (from http://www.gentooforum.de/post/107312/emerge-kbiff.html#post107312) to check the solution.

Thank you!

[Comment 3 Oliver Maurhart 2009-01-02 09:32:27 UTC]

Created attachment 177073 [details]
patch for the ebuild

[Comment 4 Oliver Maurhart 2009-01-02 09:33:53 UTC]

(In reply to comment #2)
> Hi, 
> 
> I have the same error in my ASUS laptop. Please, submit the ebuild with the
> patch (from http://www.gentooforum.de/post/107312/emerge-kbiff.html#post107312)
> to check the solution.
> 
> Thank you!

Done (Don't forget to invoke "ebuild /path/to/kbiff.ebuild manifest" do recreate the checksums)

=)

[Comment 5 Samuli Suominen (RETIRED) 2009-10-13 19:26:55 UTC]

This patch seems to be in kbiff-3.9. Now in portage.