Bug 220701

Summary:	sys-apps/portage: ignores CPPFLAGS when building tbz2tool
Product:	Portage Development	Reporter:	Jonathan Callen (RETIRED) <jcallen>
Component:	Unclassified	Assignee:	Portage team <dev-portage>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	InVCS
Priority:	High
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---

Description Jonathan Callen (RETIRED) gentoo-dev

2008-05-07 03:39:21 UTC

The ebuilds for sys-app/portage (all versions currently in the tree) ignore the value of CPPFLAGS, which is modified in the ebuild itself (in the call to append-lfs-flags).

Reproducible: Always

Steps to Reproduce:

Comment 1 Andrew Gaffney (RETIRED) gentoo-dev

2008-05-07 14:11:21 UTC

What are you talking about? Looking at the flag-o-matic eclass, append-lfs-flags() calls append-cppflags(), which does export CPPFLAGS="${CPPFLAGS} $*". Also, why do you think this is specifically a problem with the sys-apps/portage ebuilds?

Comment 2 Jonathan Callen (RETIRED) gentoo-dev

2008-05-07 16:55:57 UTC

Sorry I wasn't clearer - the ebuild sets CPPFLAGS, but in the call to gcc a few lines down, it doesn't actually pass ${CPPFLAGS} to the compiler:
    $(tc-getCC) ${CFLAGS} ${LDFLAGS} -o tbz2tool tbz2tool.c
should be:
    $(tc-getCC) ${CPPFLAGS} ${CFLAGS} ${LDFLAGS} -o tbz2tool tbz2tool.c

Comment 3 Zac Medico gentoo-dev

2008-05-10 03:12:22 UTC

Well, portage doesn't even use tbztool anymore. I think I'll opt to just not build it anymore. I doubt that anybody uses it and it would be trivial to write a python version if there's demand for it.

Comment 4 SpanKY gentoo-dev

2008-05-10 07:50:53 UTC

i'd just drop it ... we already have utilities in portage-utils to modify/extract/whatever the xpak and tbz2 packages

Comment 5 Zac Medico gentoo-dev

2008-05-10 09:35:57 UTC

This is fixed in 2.1.5_rc10 (tbz2tool is no longer installed).