Summary: | x11-misc/alock should depend on sys-libs/pam | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Hopeless <hopeless> |
Component: | New packages | Assignee: | Desktop Misc. Team <desktop-misc> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
alock-60-r3 ebuild with virtual/pam added to DEPEND
updated ebuild, controls pam via USE flag fix --with-imlib2 |
Description
Hopeless
2008-05-05 18:29:43 UTC
Created attachment 151961 [details]
alock-60-r3 ebuild with virtual/pam added to DEPEND
alock-60-r3 ebuild with virtual/pam added to DEPEND
Created attachment 152567 [details]
updated ebuild, controls pam via USE flag
I didn't realise that pam usage was actually optional, as it didn't fail configure.
This ebuild has pam and imlib2 support controlled via USE flags, and displays an einfo message informing the user that they'll need to make /usr/bin/alock SUID in order to use the system passwords without pam (the message isn't ery well worded, though...).
You could make it install suid if pam isn't enabled, or add a suid USE flag, but I think this is simpler and safer.
Other things which are enabled but acould be disabled or controlled by use flags are xrender, xcursor, xpm and hash support, and passwd support could be omitted altogether, which may be worthwhile when using pam.
Commited, thank you for testing alock. Created attachment 153677 [details]
fix --with-imlib2
The updated ebuild committed to portage has the imlib2 use flag changed to imlib, which is actually what it should have been, how ever it also changed $(use_with imlib2) to $(use_with imlib), which is ignored as --with-imlib is incorrect.
Here's another ebuild with $(use_with imlib imlib2) instead.
Re-opening because of broken USE=imlib, hope that's okay... err... looks like this is fixed in alock-94 already. |