| Summary: | media-sound/kstreamripper-0.3.4 s/cflags/cxxflags/, MAKEOPTS issues | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Duncan <1i5t5.duncan> |
| Component: | [OLD] KDE | Assignee: | Gentoo Sound Team <sound> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | 2007.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
Scons itself needs to be fixed as it doesn't handle the ${MAKEOPTS} correctly; best we can do here is to remove the ${MAKEOPTS} from ebuild. AFAIK.
But you are right, mixing CFLAGS with CXXFLAGS is plain wrong.
should be fixed now, reopen if not |
U use some C++ unfriendly flags (-freorder-blocks-and-partition -combine) in CFLAGS that I of course don't have in CXXFLAGS. I thus noticed that kstreamripper-0.3.4 seems to use CFLAGS to compile C++ code, generating unexpected warnings: cc1plus: note: -freorder-blocks-and-partition does not work with exceptions Suggested fix until upstream can change their sources appropriately, simply set CFLAGS="${CXXFLAGS}" in the ebuild so it uses the proper flag set. Also, I'm not sure if -l<number> (load average job limits) is supposed to be supported in MAKEOPTS or not, but it's certainly very useful on most compiles. Unfortunately kstreamripper doesn't like it, apparently due to the use of scons. Setting a MAKEOPTS with just -j<number> in /etc/portage/env/media-sound/kstreamripper eliminates the problem for me, but it may be worth filtering -l from MAKEOPTS in the ebuild. Actually, given the number of scons using packages, it may be worth an eclass function if there's not one already, perhaps in flagomatic? (If you want this as a different bug, say so and I'll do it, but since it might be NOTABUG/WONTFIX... .) (I don't believe emerge --info is necessary for this one. Let me know if it is or if other info would be helpful.) Duncan