Summary: | net-p2p/mldonkey-2.9.? shutdown problem and corrupted files | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ramin <gentoo> |
Component: | Current packages | Assignee: | Gentoo net-p2p team <net-p2p> |
Status: | RESOLVED OBSOLETE | ||
Severity: | normal | ||
Priority: | High | ||
Version: | 2008.0 | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Ramin
2008-05-05 14:38:18 UTC
By now I can confirm that also net-p2p/mldonkey-2.9.5 is corrupting mldonkey as well as BitTorrent downloads if shutdown during a download. MLdonkey should never be forcefully killed by "kill -9" because it may not be able to write its ini files properly. Especially when downloading torrents it may happen that shutting down MLDonkey takes ~30s because the trackers have to be notified about stopping the download. When the init script has some kind of timeout for the shutdown of MLDonkey this will interfere with properly writing ini files back to disc. (In reply to comment #2) > MLdonkey should never be forcefully killed by "kill -9" I am not killing it myself ... it is the /etc/init.d/mldonkey script itself. Your "kill -9" replacemant is the start-stop-daemon: start-stop-daemon --stop --exec "${MLDONKEY_BINARY}" \ --pidfile /var/run/"${SVCNAME}".pid > When the init script has some kind of timeout for the > shutdown of MLDonkey this will interfere with properly > writing ini files back to disc. What is your suggestion? Mabe changing MLDONKEY_TIMEOUT=${TIMEOUT:-20} to 90 seconds - should that be enough? If the solution is that simple the init.d script should be changed IMHO. (In reply to comment #2) > Especially when downloading torrents it may happen that > shutting down MLDonkey takes ~30s because the trackers > have to be notified about stopping the download. I tried 90 and 900 seconds instead of 20 but mldonkey did not stop at all. In my opinion that is the main problem and not the "kill" in the init script. > But mldonkey also often produced corrupted
> files. With the corrupted download of the
> Gentoo 2008.0_beta1 (torrent) I started testing.
I never stop mldonkey using kill-9 but always use the proper script. If it doesn't work the first time (IT ALMOST NEVER DOES), I try once more (THIS USUALLY WORKS).
From time to time I also get corrupted temporary files. I just delete all the *.tmp files from the mldonkey root directory, and everything works fine. If not, I try a backup from the old_config dir.
I'm using mldonkey 2.9.6..
I wonder if it's a problem with the gentoo's supervisor, rather than with mldonkey itself. Still, I find it distasteful that a program doesn't terminate in few seconds when it's told.
Feel free to reopen if it still happens with a recent mldonkey version |