| Summary: | x11-terms/gnome-terminal-2.22.1 doesn't kill bash processes on tab close | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | David Hardstone <dhardstone> |
| Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | esigra, magowiz, main.haarp, pacho, rahul, sven.koehler |
| Priority: | High | Keywords: | NeedPatch |
| Version: | unspecified | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| URL: | http://bugzilla.gnome.org/show_bug.cgi?id=509866 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 214260 | ||
| Attachments: | Patch to fix killing of shell when tab is closed | ||
|
Description
David Hardstone
2008-05-01 20:21:04 UTC
Same bug here indeed, doesn't happen if you type exit or hit ctrl+d in the term. Please report this upstream. And please add gnome@gentoo.org as a CC on that bug so that we can keep track of it. Thanks It was already reported by other but seems not too active :-( It was already reported by other but seems not too active :-( http://bugzilla.gnome.org/show_bug.cgi?id=509866 I've added gnome@gentoo.org and myself to the CC list for the bug on GNOME's bugzilla. I am on x11-terms/gnome-terminal-2.22.3 and have not encountered this bug. I would guess it is fixed then. Yep, x11-terms/gnome-terminal-2.22.3 appears to have fixed it for me too :)! How exactly are you guys trying to reproduce this? Because I still get this error with 2.22.3. Oh, I apologise. I've got used to pressing Ctrl+D to close tabs and I suppose I wasn't thinking when seeing whether the bug was still there. When I close the tab with the mouse or Shift+Ctrl+W, the bug is reproduced like normal. rahul@wall ~ $ ps -ef | grep tail rahul 2529 2476 0 11:50 pts/0 00:00:00 tail -f /var/log/debug rahul 2531 2493 0 11:50 pts/1 00:00:00 grep --colour=auto tail After I close the terminal, clicking on the X. :) rahul@wall ~ $ ps -ef | grep tail rahul 2533 2493 0 11:51 pts/1 00:00:00 grep --colour=auto tail So, it is killed for me. I do not have this bug. By the way, here is my emerge --info. Maybe this would help. Portage 2.2_rc3 (default/linux/x86/2008.0, gcc-4.3.1, glibc-2.8_p20080602-r0, 2.6.25-tuxonice-r6 i686) ================================================================= System uname: Linux-2.6.25-tuxonice-r6-i686-Genuine_Intel-R-_CPU_T2300_@_1.66GHz-with-glibc2.0 Timestamp of tree: Fri, 25 Jul 2008 18:15:01 +0000 app-shells/bash: 3.2_p39 dev-java/java-config: 1.3.7, 2.1.6-r1 dev-lang/python: 2.5.2-r5 sys-apps/baselayout: 2.0.0 sys-apps/openrc: 0.2.5 sys-apps/sandbox: 1.2.18.1-r3 sys-devel/autoconf: 2.13, 2.62-r1 sys-devel/automake: 1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1 sys-devel/binutils: 2.18-r3 sys-devel/gcc-config: 1.4.0-r4 sys-devel/libtool: 2.2.4 virtual/os-headers: 2.6.25-r4 ACCEPT_KEYWORDS="x86 ~x86" CBUILD="i686-pc-linux-gnu" CFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config /var/lib/hsqldb" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d" CXXFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer" DISTDIR="/usr/portage/distfiles" FEATURES="distlocks parallel-fetch preserve-libs sandbox sfperms strict unmerge-orphans userfetch" GENTOO_MIRRORS="http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/" LANG="C" LDFLAGS="-Wl,-O1" LINGUAS="hi en" MAKEOPTS="-j3" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage/layman/sunrise /usr/local/portage/layman/desktop-effects /usr/local/portage/layman/mpd /usr/local/portage/layman/zen-overlay" SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage" USE="X a52 aac acl acpi alsa avahi bash-completion berkdb bluetooth branding bzip2 cairo cdparanoia cdr cli cracklib crypt css ctype cups curl curlwrappers cxx dbus dga djvu dri dts dvd dvdr esd exif fam fbcon ffmpeg flac fontconfig fortran gd gdbm gif gimp gnome gnutls gphoto2 gpm graphviz gstreamer gtk gtkhtml hal hddtemp iconv ieee1394 imagemagick ipv6 isdnlog java java6 javascript joystick jpeg jpeg2k libnotify lm_sensors mad midi mmx mono motif mp3 mpeg mudflap ncurses nls nptl nptlonly ogg openmp oss pam pcmcia pcre perl png posix ppds pppd python quicktime readline real reflection samba scanner session smp sndfile spell spl sse sse2 sse3 ssl startup-notification svg svga syslog tcpd theora threads tiff truetype type1 unicode usb v4l v4l2 vcd vim-syntax vorbis wavpack win32codecs wmf x86 xcomposite xinerama xml xorg xpm xscreensaver xulrunner xv xvid zeroconf zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="evdev keyboard mouse synaptics joystick" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="hi en" USERLAND="GNU" VIDEO_CARDS="i810 v4l fbdev" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS Here's what I do: ---- arun@peripatetic ~ $ ps -ef | grep pts | grep bash arun 7620 7603 0 10:00 pts/0 00:00:01 -bash arun 32479 7620 0 15:44 pts/0 00:00:00 grep --colour=auto bash ---- (open a new tab) arun@peripatetic ~ $ ps -ef | grep pts | grep bash arun 7620 7603 0 10:00 pts/0 00:00:01 -bash arun 32480 7603 8 15:44 pts/1 00:00:00 -bash arun 32536 7620 0 15:44 pts/0 00:00:00 grep --colour=auto bash ---- (close the tab by pressing the button) arun@peripatetic ~ $ ps -ef | grep pts | grep bash arun 7620 7603 0 10:00 pts/0 00:00:01 -bash arun 32480 7603 3 15:44 pts/1 00:00:00 -bash arun 32539 7620 0 15:44 pts/0 00:00:00 grep --colour=auto bash ---- The bash process with PID 32480 should have been killed when the tab was closed. Right you are then. The bug only affects tabs gnome-terminal. So, if a new tab is opened and when that tab is closed, the process is not killed. Could you try this out and test this. (In reply to comment #14) > Right you are then. The bug only affects tabs gnome-terminal. So, if a new tab > is opened and when that tab is closed, the process is not killed. > Could you try this out and test this. Yep, the problem seems to occur only with closing tabs, not terminals. But if you've got a terminal open with 2 tabs, and you close one tab, then close the terminal, the bash process from the first tab you closed will continue to exist. I doubt upstream will work on a patch given the large changes in 2.23, however it shouldn't be to hard to bisect between 2.20 branch and 2.22 to find out what broke this. Created attachment 161951 [details, diff]
Patch to fix killing of shell when tab is closed
Here's a slightly modified version of the patch posted upstream. Seems to work.
@herd: is this okay to commit, or should we just wait for 2.24? I vote to commit, since having a lot of stray bash processes hanging around is no fun. :)
No way we want to wait 2.24, you can add this in a r1 when you get a decent net connection or I'll do it asap. Thanks for doing the investigation work with bheekling. (In reply to comment #18) > No way we want to wait 2.24, you can add this in a r1 when you get a decent net > connection or I'll do it asap. Hum. I don't think Arun is going to get a decent connection anytime soon. I think the best thing is for you to commit it asap. commited in r1, thanks again guys. |
