Bug 219506 – media-sound/timidity-freepats-20060219 timidity.cfg is wrong

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Albert Zeyer 2008-04-27 16:25:17 UTC]

The keywords are also a bit strange:

KEYWORDS="~amd64 ~x86-fbsd"

They already say that x86 is not supported. I though tried it and it emerges fine, but I get no sound with this patchset (other patchsets work fine for me).

But I cannot really believe that this patchset really works for x86-fbsd and not for x86. So there is a bug somewhere.

[Comment 1 Jeroen Roovers (RETIRED) 2008-04-27 18:07:28 UTC]

The ~x86-fbsd keyword was added by the maintainer (who happens to run x86-fbsd) of the package at its insertion into the tree, so let's just trust him to have tested that it does work on that OS.

Also, keywords are added as architecture developers test packages and find that they work on the architecture they tested on - the KEYWORDS variable only conveys that a package will definitely not work on a specific architecture when it is marked `-arch'.

Lastly, it seems your timidity configuration must have been broken when you tested on x86 - instrument patches are architecture independent, and most packages are still mostly developed and thoroughly tested on x86 systems. If you find that you can get these patches to work, then please reopen this bug and change its summary to ask for an ~x86 marking.

[Comment 2 Albert Zeyer 2008-04-27 18:25:58 UTC]

(In reply to comment #1)
> Lastly, it seems your timidity configuration must have been broken when you
> tested on x86 - instrument patches are architecture independent, and most
> packages are still mostly developed and thoroughly tested on x86 systems.

Exactly this was also my thought.

Though, the other patchsets work without problems (that are eawpatches and shompatches). I haven't changed anything in my timidity configuration and I select the patchset via eselect.

I tried to debug it further now a bit with freepats.

I have run timidity from console now and I get:

macbook ~ # timidity   /home/az/Programmierung/MidiWriter/song2.mid 
Requested buffer size 32768, fragment size 8192
ALSA pcm 'default' set buffer size 30104, period size 3760 bytes
Playing /home/az/Programmierung/MidiWriter/song2.mid
MIDI file: /home/az/Programmierung/MidiWriter/song2.mid
Format: 1  Tracks: 2  Divisions: 480
Copyright: Albert Zeyer
Track name: Klavier
Instrument `Tone_000/000_Acoustic_Grand_Piano.pat' can't be found.
Couldn't load instrument Tone_000/000_Acoustic_Grand_Piano.pat (tone bank 0, program 0)
Instrument `Tone_000/000_Acoustic_Grand_Piano.pat' can't be found.
No pre-resampling cache hit
(made with Linux)(http://www.az2000.de)(The Song 1)Terminated sig=0x02

I looked into the other specific timidity.cfg and for example eawpatches have the following line:
    dir /usr/share/timidity/eawpatches
shompatches has a similar line in its timidity.cfg. But freepats does not!

I added therefore the line
    dir /usr/share/timidity/freepats
to /usr/share/timidity/freepats/timidity.cfg.

And, oh wonder, it worked after! :)

[Comment 3 Albert Zeyer 2008-04-27 18:34:17 UTC]

Small change to the ebuild:

src_compile() {
    echo "dir /usr/share/timidity/freepats" > timidity.cfg
    cat freepats.cfg >> timidity.cfg
}

src_install() {
    insinto /usr/share/timidity/${MY_PN}

    doins -r timidity.cfg Drum_000 Tone_000

    dodoc README
}

After that, I got a working installation of freepats.

So please apply this and add ~x86.

[Comment 4 Jeroen Roovers (RETIRED) 2008-04-27 19:13:05 UTC]

Configuring timidity is what app-admin/eselect-timidity is designed to do... The ebuild shouldn't do it on the sysadmin's behalf.

CC'ing x86 for the purpose of keywording.

[Comment 5 Albert Zeyer 2008-04-27 19:52:50 UTC]

eselect-timidity should not touch /usr/share/timidity/freepats/timidity.cfg. This file is installed by the ebuild and should never be modified.

And this file is wrong, this dir-specification is missing.

[Comment 6 Markus Meier 2008-05-01 15:16:43 UTC]

~x86 added.

[Comment 7 Albert Zeyer 2008-05-01 20:03:58 UTC]

Please apply my patch in some form, it's broken without.

/usr/share/timidity/freepats/timidity.cfg is broken.

As I said, the 'dir' command has to be in there, else it won't work (with the reasons I have explained already). Compare also with /usr/share/timidity/eawpatches/timidity.cfg.

[Comment 8 Samuli Suominen (RETIRED) 2009-05-12 17:21:52 UTC]

*** Bug 253316 has been marked as a duplicate of this bug. ***

[Comment 9 Samuli Suominen (RETIRED) 2009-05-12 17:30:17 UTC]

+  12 May 2009; Samuli Suominen <[e-mail]>
+  timidity-freepats-20060219.ebuild:
+  Add /usr/share/timidity/freepats to timidity.cfg for instruments to be
+  found wrt #219506.